Files.app: Fix DCHECK in FakeFileSystem.

chrome/browser/chromeos/drive/fake_file_system.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/fake_file_system.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
@@ skipping 127 matching lines @@
                  weak_ptr_factory_.GetWeakPtr(),
                  initialized_callback, get_content_callback,
                  completion_callback));
   return base::Bind(&base::DoNothing);
 }
 
 void FakeFileSystem::GetResourceEntry(
     const base::FilePath& file_path,
     const GetResourceEntryCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(file_path.BaseName() != file_path);

[kinaba, 2014/09/19 01:47:18]

The condition looks a bit detouring.

What we want to enforce here is that all paths must be under "My Drive",
according to the comment below. Then, what about asserting in that way? For
instance, like putting

DCHECK(util::GetDriveMyDriveRootPath().IsParent(file_path));

after the if branch (an before the GetResourceEntry(file_path.DirName()) call).

[hirono, 2014/09/22 04:53:28]

Let me do this. Thank you!

 
   // Now, we only support files under my drive.
-  DCHECK(!util::IsUnderDriveMountPoint(file_path));
-
   if (file_path == util::GetDriveMyDriveRootPath()) {
     // Specialized for the root entry.
     drive_service_->GetAboutResource(
         base::Bind(
             &FakeFileSystem::GetResourceEntryAfterGetAboutResource,
             weak_ptr_factory_.GetWeakPtr(), callback));
     return;
   }
 
   GetResourceEntry(
@@ skipping 225 matching lines @@
       callback.Run(FILE_ERROR_OK, entry.Pass());
       return;
     }
   }
 
   callback.Run(FILE_ERROR_NOT_FOUND, scoped_ptr<ResourceEntry>());
 }
 
 }  // namespace test_util
 }  // namespace drive