Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 583363002: Ignore MISSING_VIA_HEADER_OTHER bypasses if in relevant finch trial (Closed)

Created:
6 years, 3 months ago by sclittle
Modified:
6 years, 3 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ignore MISSING_VIA_HEADER_OTHER bypasses if in relevant finch trial For clients that are part of the finch trial, change the proxy bypass logic to not trigger a proxy bypass when a response with a non-4xx response code is expected to have the data reduction proxy header, but the data reduction proxy via header is missing. BUG=413035 Committed: https://crrev.com/dadcc31e94943d59ecef9209e09a557d1594b68a Cr-Commit-Position: refs/heads/master@{#295825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_params.h View 1 chunk +7 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_params.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sclittle
bengr: all Thanks in advance
6 years, 3 months ago (2014-09-19 20:54:36 UTC) #2
bengr
lgtm
6 years, 3 months ago (2014-09-19 21:44:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583363002/1
6 years, 3 months ago (2014-09-19 21:47:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2d2bbab0e04398b376e932df42b076ccaa1524df
6 years, 3 months ago (2014-09-20 00:08:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 00:08:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dadcc31e94943d59ecef9209e09a557d1594b68a
Cr-Commit-Position: refs/heads/master@{#295825}

Powered by Google App Engine
This is Rietveld 408576698