Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Issue 583363002: Ignore MISSING_VIA_HEADER_OTHER bypasses if in relevant finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/browser/data_reduction_proxy_params.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_ 5 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
6 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_ 6 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 // proxy if the request resource type is on the critical path (e.g. HTML). 76 // proxy if the request resource type is on the critical path (e.g. HTML).
77 static bool IsIncludedInCriticalPathBypassFieldTrial(); 77 static bool IsIncludedInCriticalPathBypassFieldTrial();
78 78
79 // Returns true if this client is part of a field trial that runs a holdback 79 // Returns true if this client is part of a field trial that runs a holdback
80 // experiment. A holdback experiment is one in which a fraction of browser 80 // experiment. A holdback experiment is one in which a fraction of browser
81 // instances will not be configured to use the data reduction proxy even if 81 // instances will not be configured to use the data reduction proxy even if
82 // users have enabled it to be used. The UI will not indicate that a holdback 82 // users have enabled it to be used. The UI will not indicate that a holdback
83 // is in effect. 83 // is in effect.
84 static bool IsIncludedInHoldbackFieldTrial(); 84 static bool IsIncludedInHoldbackFieldTrial();
85 85
86 // Returns true if this client is part of a field trial that removes the
87 // |MISSING_VIA_HEADER_OTHER| proxy bypass case. This experiment changes proxy
88 // bypass logic to not trigger a proxy bypass when a response with a non-4xx
89 // response code is expected to have a data reduction proxy via header, but
90 // the data reduction proxy via header is missing.
91 static bool IsIncludedInRemoveMissingViaHeaderOtherBypassFieldTrial();
92
86 // Constructs configuration parameters. If |kAllowed|, then the standard 93 // Constructs configuration parameters. If |kAllowed|, then the standard
87 // data reduction proxy configuration is allowed to be used. If 94 // data reduction proxy configuration is allowed to be used. If
88 // |kfallbackAllowed| a fallback proxy can be used if the primary proxy is 95 // |kfallbackAllowed| a fallback proxy can be used if the primary proxy is
89 // bypassed or disabled. If |kAlternativeAllowed| then an alternative proxy 96 // bypassed or disabled. If |kAlternativeAllowed| then an alternative proxy
90 // configuration is allowed to be used. This alternative configuration would 97 // configuration is allowed to be used. This alternative configuration would
91 // replace the primary and fallback proxy configurations if enabled. Finally 98 // replace the primary and fallback proxy configurations if enabled. Finally
92 // if |kPromoAllowed|, the client may show a promotion for the data reduction 99 // if |kPromoAllowed|, the client may show a promotion for the data reduction
93 // proxy. 100 // proxy.
94 // 101 //
95 // A standard configuration has a primary proxy, and a fallback proxy for 102 // A standard configuration has a primary proxy, and a fallback proxy for
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 bool fallback_allowed_; 291 bool fallback_allowed_;
285 bool alt_allowed_; 292 bool alt_allowed_;
286 bool promo_allowed_; 293 bool promo_allowed_;
287 bool holdback_; 294 bool holdback_;
288 295
289 bool configured_on_command_line_; 296 bool configured_on_command_line_;
290 }; 297 };
291 298
292 } // namespace data_reduction_proxy 299 } // namespace data_reduction_proxy
293 #endif // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H _ 300 #endif // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H _
OLDNEW
« no previous file with comments | « no previous file | components/data_reduction_proxy/browser/data_reduction_proxy_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698