Open just folder menu on middle clicking chevron button.

Open just folder menu on middle clicking chevron button.

In common openBookmarkFolder: function, check if button is offTheSideButton and
event is NSOtherMouseUp, if so, open just the folder menu instead of opening all
bookmarks under it.

BUG=46682
R=asvitkine@chromium.org

TEST=
1) Launch chrome and add more bookmarks to Bookmarks bar so that offTheSideButton
is visible.
2) Middle click on the button and observe.
3) It should just open its folder menu instead of opening all bookmarks under it.

Committed: https://crrev.com/1e5f714262659081b565725a4c17890deefaae14
Cr-Commit-Position: refs/heads/master@{#295981}

[Gaja, 2014-09-19 14:36:30]

@asvitkine 
Please take a look. Thanks.

[Alexei Svitkine (slow), 2014-09-19 15:50:00]

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:733: // Function to
open bookmark folder of offTheSideButton.
Nit: This comment doesn't add anything that the name of the function doesn't
say, so just omit.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:734: -
(void)openFolderForOffTheSideButton:(id)sender {
Nit: Since this can close it too, how about "openOrCloseFolder..."

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:736: if
([folderController_ parentButton] == sender)
From the code, looks like |sender| will always be |offTheSideButton_|, so I
don't think it's necessary to pass it as a param. Remove the param and change
this check to == offTheSideButton_ instead.

[Gaja, 2014-09-20 05:35:45]

Thanks for the review. I do not have access to MAC PC at home. I will upload
Patch Set #2 addressing your comments, on monday(from my office). I regret for
the delay.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:733: // Function to
open bookmark folder of offTheSideButton.
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> Nit: This comment doesn't add anything that the name of the function doesn't
> say, so just omit.

Acknowledged.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:734: -
(void)openFolderForOffTheSideButton:(id)sender {
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> Nit: Since this can close it too, how about "openOrCloseFolder..."

Acknowledged.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:736: if
([folderController_ parentButton] == sender)
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> From the code, looks like |sender| will always be |offTheSideButton_|, so I
> don't think it's necessary to pass it as a param. Remove the param and change
> this check to == offTheSideButton_ instead.

Acknowledged.

[Gaja, 2014-09-22 03:34:41]

@asvitkine,
Changes in Patch Set #2. Please review.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm (right):

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:733: // Function to
open bookmark folder of offTheSideButton.
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> Nit: This comment doesn't add anything that the name of the function doesn't
> say, so just omit.

Done.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:734: -
(void)openFolderForOffTheSideButton:(id)sender {
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> Nit: Since this can close it too, how about "openOrCloseFolder..."

Done.

https://codereview.chromium.org/583223002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm:736: if
([folderController_ parentButton] == sender)
On 2014/09/19 15:49:59, Alexei Svitkine wrote:
> From the code, looks like |sender| will always be |offTheSideButton_|, so I
> don't think it's necessary to pass it as a param. Remove the param and change
> this check to == offTheSideButton_ instead.

Done.

[Alexei Svitkine (slow), 2014-09-22 14:56:44]

lgtm

[Gaja, 2014-09-22 15:28:37]

The CQ bit was checked by gajendra.n@samsung.com

[commit-bot: I haz the power, 2014-09-22 15:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583223002/20001

[commit-bot: I haz the power, 2014-09-22 16:13:30]

Committed patchset #2 (id:20001) as 2f9cadf79ee9aa383a44a43b21a4069b953441cd

[commit-bot: I haz the power, 2014-09-22 16:14:20]

Patchset 2 (id:??) landed as
https://crrev.com/1e5f714262659081b565725a4c17890deefaae14
Cr-Commit-Position: refs/heads/master@{#295981}