Open just folder menu on middle clicking chevron button.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
@@ skipping 698 matching lines @@
 // Common function to open a bookmark folder of any type.
 - (void)openBookmarkFolder:(id)sender {
   DCHECK([sender isKindOfClass:[BookmarkButton class]]);
   DCHECK([[sender cell] isKindOfClass:[BookmarkButtonCell class]]);
 
   // Only record the action if it's the initial folder being opened.
   if (!showFolderMenus_)
     RecordBookmarkFolderOpen([self bookmarkLaunchLocation]);
   showFolderMenus_ = !showFolderMenus_;
 
-  if (sender == offTheSideButton_)
+  // Middle click on chevron should not open bookmarks under it, instead just
+  // open its folder menu.
+  if (sender == offTheSideButton_) {
     [[sender cell] setStartingChildIndex:displayedButtonCount_];
-
+    NSEvent* event = [NSApp currentEvent];
+    if ([event type] == NSOtherMouseUp) {
+      [self openFolderForOffTheSideButton:sender];
+      return;
+    }
+  }
   // Toggle presentation of bar folder menus.
   [folderTarget_ openBookmarkFolderFromButton:sender];
 }
 
+// Function to open bookmark folder of offTheSideButton.

[Alexei Svitkine (slow), 2014/09/19 15:49:59]

Nit: This comment doesn't add anything that the name of the function doesn't
say, so just omit.

[Gaja, 2014/09/20 05:35:44]

Acknowledged.

[Gaja, 2014/09/22 03:34:40]

Done.

+- (void)openFolderForOffTheSideButton:(id)sender {

[Alexei Svitkine (slow), 2014/09/19 15:49:59]

Nit: Since this can close it too, how about "openOrCloseFolder..."

[Gaja, 2014/09/20 05:35:44]

Acknowledged.

[Gaja, 2014/09/22 03:34:40]

Done.

+  // If clicked on already opened folder, then close it and return.
+  if ([folderController_ parentButton] == sender)

[Alexei Svitkine (slow), 2014/09/19 15:49:59]

From the code, looks like |sender| will always be |offTheSideButton_|, so I
don't think it's necessary to pass it as a param. Remove the param and change
this check to == offTheSideButton_ instead.

[Gaja, 2014/09/20 05:35:44]

Acknowledged.

[Gaja, 2014/09/22 03:34:40]

Done.

+    [self closeBookmarkFolder:self];
+  else
+    [self addNewFolderControllerWithParentButton:sender];
+}
+
 // Click on a bookmark folder button.
 - (IBAction)openBookmarkFolderFromButton:(id)sender {
   [self openBookmarkFolder:sender];
 }
 
 // Click on the "off the side" button (chevron), which opens like a folder
 // button but isn't exactly a parent folder.
 - (IBAction)openOffTheSideFolderFromButton:(id)sender {
   [self openBookmarkFolder:sender];
 }
@@ skipping 2062 matching lines @@
 - (id<BookmarkButtonControllerProtocol>)controllerForNode:
     (const BookmarkNode*)node {
   // See if it's in the bar, then if it is in the hierarchy of visible
   // folder menus.
   if (bookmarkModel_->bookmark_bar_node() == node)
     return self;
   return [folderController_ controllerForNode:node];
 }
 
 @end