help: remove hash+ref+position from chrome://help page.

help: remove hash+ref+position from chrome://help page.

R=michaelpg@chromium.org
BUG=416133
Committed: https://crrev.com/cf516a30ceadae186272d8442a3ee195c25ace87
Cr-Commit-Position: refs/heads/master@{#295834}

[michaelpg, 2014-09-19 20:58:05]

lgtm

our templating system is soo elegant

On Fri, Sep 19, 2014 at 1:54 PM, <dbeam@chromium.org> wrote:

> Reviewers: michaelpg,
>
> Description:
> help: remove hash+ref+position from chrome://help page for official builds.
>
> R=michaelpg@chromium.org
> BUG=416133
>
> Please review this at https://codereview.chromium.org/583193007/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+5, -0 lines):
>   M chrome/browser/resources/help/help_content.html
>
>
> Index: chrome/browser/resources/help/help_content.html
> diff --git a/chrome/browser/resources/help/help_content.html
> b/chrome/browser/resources/help/help_content.html
> index 5fc96ebd27b08d53d6e116a05c8d80820f0153f9..
> e0dd1c923413e08304d55e3daacc5b14c8b3d271 100644
> --- a/chrome/browser/resources/help/help_content.html
> +++ b/chrome/browser/resources/help/help_content.html
> @@ -13,7 +13,12 @@
>  </if>
>    </div>
>    <div id="version-container">
> +<if expr="_google_chrome">
> +    <div i18n-content="browserVersion" dir="ltr"></div>
> +</if>
> +<if expr="not _google_chrome">
>      <div i18n-values=".innerHTML:browserVersionLongHtml" dir="ltr"></div>
> +</if>
>  <if expr="chromeos">
>      <div>
>        <span i18n-content="platform"></span>&nbsp;<span
> id="os-version"></span>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[michaelpg, 2014-09-19 20:58:43]

still lgtm

[Dan Beam, 2014-09-19 21:13:30]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-19 21:15:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583193007/20001

[Dan Beam, 2014-09-19 22:16:32]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2014-09-19 22:28:19]

talked with pkasting@ over crbug.com, we thought it'd be better to just remove
sha1 from chrome://help completely.  so we're more-or-less back to square one,
-4 lines of code (just no rev now).

[michaelpg, 2014-09-19 22:32:04]

lgtm++

thanks

[Dan Beam, 2014-09-19 22:34:18]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583193007/40001

[commit-bot: I haz the power, 2014-09-20 00:40:47]

Committed patchset #3 (id:40001) as 0bce3872ea604c50ee8a634d5e8bae7c16c87843

[commit-bot: I haz the power, 2014-09-20 00:41:26]

Patchset 3 (id:??) landed as
https://crrev.com/cf516a30ceadae186272d8442a3ee195c25ace87
Cr-Commit-Position: refs/heads/master@{#295834}