help: remove hash+ref+position from chrome://help page.

chrome/browser/ui/webui/help/help_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 94 matching lines @@
   } else if (user_manager::UserManager::Get()->IsCurrentUserOwner()) {
     // On non managed machines we have local owner who is the only one to change
     // anything. Ensure that ReleaseChannelDelegated is false.
     return !value;
   }
   return false;
 }
 
 #endif  // defined(OS_CHROMEOS)
 
-base::string16 BrowserVersionString(bool long_html) {
-  chrome::VersionInfo version_info;
-  DCHECK(version_info.is_valid());
-
-  std::string version = version_info.Version();
-
-  std::string modifier = chrome::VersionInfo::GetVersionStringModifier();
-  if (!modifier.empty())
-    version += " " + modifier;
-
-#if defined(ARCH_CPU_64_BITS)
-  version += " (64-bit)";
-#endif
-
-  if (long_html)
-    version += "<br>(" + version_info.LastChange() + ")";
-
-  return base::UTF8ToUTF16(version);
-}
-
 }  // namespace
 
 HelpHandler::HelpHandler()
     : version_updater_(VersionUpdater::Create()),
       weak_factory_(this) {
 }
 
 HelpHandler::~HelpHandler() {
 }
 
@@ skipping 82 matching lines @@
       "updateObsoleteSystem",
       ObsoleteSystemMac::LocalizedObsoleteSystemString());
   localized_strings->SetString(
       "updateObsoleteSystemURL",
       chrome::kMac32BitDeprecationURL);
 #endif
 
   localized_strings->SetString(
       "browserVersion",
       l10n_util::GetStringFUTF16(IDS_ABOUT_PRODUCT_VERSION,
-                                 BrowserVersionString(false)));
-  localized_strings->SetString(
-      "browserVersionLongHtml",
-      l10n_util::GetStringFUTF16(IDS_ABOUT_PRODUCT_VERSION,
-                                 BrowserVersionString(true)));
+                                 BuildBrowserVersionString()));
 
   base::Time::Exploded exploded_time;
   base::Time::Now().LocalExplode(&exploded_time);
   localized_strings->SetString(
       "productCopyright",
        l10n_util::GetStringFUTF16(IDS_ABOUT_VERSION_COPYRIGHT,
                                   base::IntToString16(exploded_time.year)));
 
   base::string16 license = l10n_util::GetStringFUTF16(
       IDS_ABOUT_VERSION_LICENSE,
@@ skipping 76 matching lines @@
       RequestUpdate(NULL);
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
 // static
 base::string16 HelpHandler::BuildBrowserVersionString() {
-  return BrowserVersionString(false);
+  chrome::VersionInfo version_info;
+  DCHECK(version_info.is_valid());
+
+  std::string version = version_info.Version();
+
+  std::string modifier = chrome::VersionInfo::GetVersionStringModifier();
+  if (!modifier.empty())
+    version += " " + modifier;
+
+#if defined(ARCH_CPU_64_BITS)
+  version += " (64-bit)";
+#endif
+
+  return base::UTF8ToUTF16(version);
 }
 
 void HelpHandler::OnPageLoaded(const base::ListValue* args) {
 #if defined(OS_CHROMEOS)
   // Version information is loaded from a callback
   loader_.GetVersion(
       chromeos::VersionLoader::VERSION_FULL,
       base::Bind(&HelpHandler::OnOSVersion, base::Unretained(this)),
       &tracker_);
   loader_.GetFirmware(
@@ skipping 215 matching lines @@
   web_ui()->CallJavascriptFunction(
       "help.HelpPage.updateCurrentChannel", base::StringValue(channel));
 }
 
 void HelpHandler::OnTargetChannel(const std::string& channel) {
   web_ui()->CallJavascriptFunction(
       "help.HelpPage.updateTargetChannel", base::StringValue(channel));
 }
 
 #endif // defined(OS_CHROMEOS)