Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 583163002: ARM: Make stack limit stricter to account for large buffers in MacroAssembler. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ARM: Make stack limit stricter to account for large buffers in MacroAssembler. BUG=405338 LOG=Y R=rmcilroy@chromium.org, rodolph.perfetta@arm.com Committed: https://code.google.com/p/v8/source/detail?r=24079

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/globals.h View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ulan
PTAL. This is another fix for issue 405338 and replaces https://codereview.chromium.org/555943003
6 years, 3 months ago (2014-09-19 09:40:26 UTC) #2
rmcilroy
On 2014/09/19 09:40:26, ulan wrote: > PTAL. This is another fix for issue 405338 and ...
6 years, 3 months ago (2014-09-19 09:58:24 UTC) #3
Rodolph Perfetta (ARM)
lgtm
6 years, 3 months ago (2014-09-19 09:59:04 UTC) #4
ulan
6 years, 3 months ago (2014-09-19 11:26:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698