Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: src/globals.h

Issue 583163002: ARM: Make stack limit stricter to account for large buffers in MacroAssembler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_GLOBALS_H_ 5 #ifndef V8_GLOBALS_H_
6 #define V8_GLOBALS_H_ 6 #define V8_GLOBALS_H_
7 7
8 #include "include/v8stdint.h" 8 #include "include/v8stdint.h"
9 9
10 #include "src/base/build_config.h" 10 #include "src/base/build_config.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 #define USE_SIMULATOR 1 61 #define USE_SIMULATOR 1
62 #endif 62 #endif
63 #if (V8_TARGET_ARCH_MIPS64 && !V8_HOST_ARCH_MIPS64) 63 #if (V8_TARGET_ARCH_MIPS64 && !V8_HOST_ARCH_MIPS64)
64 #define USE_SIMULATOR 1 64 #define USE_SIMULATOR 1
65 #endif 65 #endif
66 #endif 66 #endif
67 67
68 // Determine whether the architecture uses an out-of-line constant pool. 68 // Determine whether the architecture uses an out-of-line constant pool.
69 #define V8_OOL_CONSTANT_POOL 0 69 #define V8_OOL_CONSTANT_POOL 0
70 70
71 #ifdef V8_TARGET_ARCH_ARM
72 // Set stack limit lower for ARM than for other architectures because
73 // stack allocating MacroAssembler takes 120K bytes.
74 // See issue crbug.com/405338
75 #define V8_DEFAULT_STACK_SIZE_KB 864
76 #else
77 // Slightly less than 1MB, since Windows' default stack size for
78 // the main execution thread is 1MB for both 32 and 64-bit.
79 #define V8_DEFAULT_STACK_SIZE_KB 984
80 #endif
81
82
71 // Support for alternative bool type. This is only enabled if the code is 83 // Support for alternative bool type. This is only enabled if the code is
72 // compiled with USE_MYBOOL defined. This catches some nasty type bugs. 84 // compiled with USE_MYBOOL defined. This catches some nasty type bugs.
73 // For instance, 'bool b = "false";' results in b == true! This is a hidden 85 // For instance, 'bool b = "false";' results in b == true! This is a hidden
74 // source of bugs. 86 // source of bugs.
75 // However, redefining the bool type does have some negative impact on some 87 // However, redefining the bool type does have some negative impact on some
76 // platforms. It gives rise to compiler warnings (i.e. with 88 // platforms. It gives rise to compiler warnings (i.e. with
77 // MSVC) in the API header files when mixing code that uses the standard 89 // MSVC) in the API header files when mixing code that uses the standard
78 // bool with code that uses the redefined version. 90 // bool with code that uses the redefined version.
79 // This does not actually belong in the platform code, but needs to be 91 // This does not actually belong in the platform code, but needs to be
80 // defined here because the platform code uses bool, and platform.h is 92 // defined here because the platform code uses bool, and platform.h is
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 801
790 inline bool IsConciseMethod(FunctionKind kind) { 802 inline bool IsConciseMethod(FunctionKind kind) {
791 DCHECK(IsValidFunctionKind(kind)); 803 DCHECK(IsValidFunctionKind(kind));
792 return kind & FunctionKind::kConciseMethod; 804 return kind & FunctionKind::kConciseMethod;
793 } 805 }
794 } } // namespace v8::internal 806 } } // namespace v8::internal
795 807
796 namespace i = v8::internal; 808 namespace i = v8::internal;
797 809
798 #endif // V8_GLOBALS_H_ 810 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698