Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 583113002: Abstract class WebTestDelegate to chromium c++ style. (Closed)

Created:
6 years, 3 months ago by Abhishek
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Abstract class WebTestDelegate to chromium c++ style. BUG=331299 Committed: https://crrev.com/ca9b560821da207006fa8d8e1f30ef62fe72c94f Cr-Commit-Position: refs/heads/master@{#295675}

Patch Set 1 #

Patch Set 2 : update test_runner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -514 lines) Patch
M content/content_shell.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D content/shell/renderer/test_runner/WebTestDelegate.h View 1 chunk +0 lines, -175 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M content/shell/renderer/test_runner/spell_check_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 28 chunks +67 lines, -67 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/web_permissions.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A content/shell/renderer/test_runner/web_test_delegate.h View 1 chunk +192 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 37 chunks +84 lines, -85 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 2 chunks +47 lines, -47 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 12 chunks +53 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Abhishek
PTAL !
6 years, 3 months ago (2014-09-19 06:07:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm.
6 years, 3 months ago (2014-09-19 06:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583113002/20001
6 years, 3 months ago (2014-09-19 06:38:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e9de3502f386cee4e1b932a1f2f2cc32878e139a
6 years, 3 months ago (2014-09-19 07:33:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 07:34:38 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ca9b560821da207006fa8d8e1f30ef62fe72c94f
Cr-Commit-Position: refs/heads/master@{#295675}

Powered by Google App Engine
This is Rietveld 408576698