QUIC - Don't close the QUIC connection if server config update message

net/quic/quic_crypto_client_stream.cc

Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index 4d9d032a9041b0c9827818d6d4f6564fe45448cc..4b7fbb55516c7a07176b17211fa85a3a9776a425 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -458,7 +458,10 @@ void QuicCryptoClientStream::DoInitializeServerConfigUpdate(
     // Note that we verify the proof even if the cached proof is valid.
     DCHECK(crypto_config_->proof_verifier());
     next_state_ = STATE_VERIFY_PROOF;
+    return;
   }
+  UMA_HISTOGRAM_COUNTS("Net.QuicNumServerConfigUpdateMessagesIgnored", 1);

[Alexei Svitkine (slow), 2014/09/19 15:14:17]

This would probably be better served with an UMA_HISTOGRAM_BOOOLEAN() since
you're always logging a 1 (equivalent to true).

Once you change it to a boolean, you probably also want to add a normalizing
factor - i.e. what does the absolute number of these really mean? Why not count
the number of server config updates as the "false" value of the histogram and
then you can get a percentage by comparing the two... Or have "false" log when
it's _not_ ignored.

[ramant (doing other things), 2014/09/19 17:00:04]

Done.

+  next_state_ = STATE_VERIFY_PROOF_DONE;
 }
 
 QuicAsyncStatus QuicCryptoClientStream::DoVerifyProof(