QUIC - Don't close the QUIC connection if server config update message

net/quic/quic_crypto_client_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_crypto_client_stream.h"
 
 #include "base/metrics/histogram.h"
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/crypto/crypto_utils.h"
 #include "net/quic/crypto/null_encrypter.h"
@@ skipping 440 matching lines @@
   if (!server_id_.is_https()) {
     // We don't check the certificates for insecure QUIC connections.
     SetCachedProofValid(cached);
     next_state_ = STATE_VERIFY_PROOF_DONE;
     return;
   }
   if (!cached->IsEmpty() && !cached->signature().empty()) {
     // Note that we verify the proof even if the cached proof is valid.
     DCHECK(crypto_config_->proof_verifier());
     next_state_ = STATE_VERIFY_PROOF;
+    return;
   }
+  UMA_HISTOGRAM_COUNTS("Net.QuicNumServerConfigUpdateMessagesIgnored", 1);

[Alexei Svitkine (slow), 2014/09/19 15:14:17]

This would probably be better served with an UMA_HISTOGRAM_BOOOLEAN() since
you're always logging a 1 (equivalent to true).

Once you change it to a boolean, you probably also want to add a normalizing
factor - i.e. what does the absolute number of these really mean? Why not count
the number of server config updates as the "false" value of the histogram and
then you can get a percentage by comparing the two... Or have "false" log when
it's _not_ ignored.

[ramant (doing other things), 2014/09/19 17:00:04]

Done.

+  next_state_ = STATE_VERIFY_PROOF_DONE;
 }
 
 QuicAsyncStatus QuicCryptoClientStream::DoVerifyProof(
     QuicCryptoClientConfig::CachedState* cached) {
   ProofVerifier* verifier = crypto_config_->proof_verifier();
   DCHECK(verifier);
   next_state_ = STATE_VERIFY_PROOF_COMPLETE;
   generation_counter_ = cached->generation_counter();
 
   ProofVerifierCallbackImpl* proof_verify_callback =
@@ skipping 83 matching lines @@
     }
   }
   return false;
 }
 
 QuicClientSessionBase* QuicCryptoClientStream::client_session() {
   return reinterpret_cast<QuicClientSessionBase*>(session());
 }
 
 }  // namespace net