Issue 583023002: Move paint code from RenderBlockFlow into BlockFlowPainter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 583023002: Move paint code from RenderBlockFlow into BlockFlowPainter. (Closed)

Created:
6 years, 3 months ago by chrishtr

Modified:
6 years, 3 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, rune+blink, zoltan1, slimming-paint-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move paint code from RenderBlockFlow into BlockFlowPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182349

Patch Set 1 #

Patch Set 2 : Finish. #

Patch Set 3 : Fix #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -45 lines)			Patch
M	Source/core/core.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	Source/core/paint/BlockFlowPainter.h	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A	Source/core/paint/BlockFlowPainter.cpp	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	1	3 chunks	+21 lines, -18 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View	1	2 chunks	+2 lines, -26 lines	0 comments	Download
M	Source/core/rendering/RenderTableCell.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583023002/40001

6 years, 3 months ago (2014-09-19 18:09:01 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 19:31:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 182349

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages