Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 583003002: Make Android about:version page more similar to other platforms. (Closed)

Created:
6 years, 3 months ago by newt (away)
Modified:
6 years, 3 months ago
Reviewers:
gone, Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Android about:version page more similar to other platforms. Chrome for Android can use the same code for displaying the application version on the about:version page as other platforms. There's no need to special-case it. Committed: https://crrev.com/4da78f3fc41cc4adfcc75ab943893fc359f3d2c1 Cr-Commit-Position: refs/heads/master@{#295746}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/about_version.html View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
newt (away)
PTAL
6 years, 3 months ago (2014-09-18 23:56:32 UTC) #2
newt (away)
+dfalcantara who may have some perspective on why we diverged in the first place (http://crbug.com/140042). ...
6 years, 3 months ago (2014-09-18 23:59:47 UTC) #4
gone
On 2014/09/18 23:59:47, newt wrote: > +dfalcantara who may have some perspective on why we ...
6 years, 3 months ago (2014-09-19 00:26:50 UTC) #5
newt (away)
Ah, according to Dan, chrome::VersionInfo was not fully implemented for Android way back when the ...
6 years, 3 months ago (2014-09-19 00:28:59 UTC) #6
Evan Stade
lgtm
6 years, 3 months ago (2014-09-19 00:33:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583003002/1
6 years, 3 months ago (2014-09-19 00:41:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/5583) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/5455) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-19 00:46:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583003002/20001
6 years, 3 months ago (2014-09-19 17:51:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a052167261b5e1b359325b046c382b3e9b0143a0
6 years, 3 months ago (2014-09-19 18:40:44 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:41:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4da78f3fc41cc4adfcc75ab943893fc359f3d2c1
Cr-Commit-Position: refs/heads/master@{#295746}

Powered by Google App Engine
This is Rietveld 408576698