Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 583003002: Make Android about:version page more similar to other platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/version_ui.cc
diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc
index 8bd94575b590dcc7c385f85432fa7542aea02d18..2f17075c4b528d95ea9c3eeac095133aeead101c 100644
--- a/chrome/browser/ui/webui/version_ui.cc
+++ b/chrome/browser/ui/webui/version_ui.cc
@@ -44,6 +44,7 @@ content::WebUIDataSource* CreateVersionUIDataSource(Profile* profile) {
// Localized and data strings.
html_source->AddLocalizedString("title", IDS_ABOUT_VERSION_TITLE);
+ html_source->AddLocalizedString("application_label", IDS_PRODUCT_NAME);
chrome::VersionInfo version_info;
html_source->AddString("version", version_info.Version());
html_source->AddString("version_modifier",
@@ -56,22 +57,11 @@ content::WebUIDataSource* CreateVersionUIDataSource(Profile* profile) {
html_source->AddString("js_version", v8::V8::GetVersion());
#if defined(OS_ANDROID)
- html_source->AddLocalizedString("application_label",
- IDS_ABOUT_VERSION_APPLICATION);
html_source->AddString("os_version", AndroidAboutAppInfo::GetOsInfo());
- base::android::BuildInfo* android_build_info =
- base::android::BuildInfo::GetInstance();
- html_source->AddString("application_name",
- android_build_info->package_label());
- html_source->AddString("application_version_name",
- android_build_info->package_version_name());
- html_source->AddString("application_version_code",
- android_build_info->package_version_code());
html_source->AddLocalizedString("build_id_name",
IDS_ABOUT_VERSION_BUILD_ID);
html_source->AddString("build_id", CHROME_BUILD_ID);
#else
- html_source->AddLocalizedString("application_label", IDS_PRODUCT_NAME);
html_source->AddString("os_version", std::string());
html_source->AddString("flash_plugin", "Flash");
// Note that the Flash version is retrieve asynchronously and returned in
« no previous file with comments | « chrome/browser/resources/about_version.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698