Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: components/sync_driver/generic_change_processor.h

Issue 582913002: Make GenericChangeProcessor upload attachments on startup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync_driver/generic_change_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/generic_change_processor.h
diff --git a/components/sync_driver/generic_change_processor.h b/components/sync_driver/generic_change_processor.h
index 05a7368a65ef67e47a517400ec84a2f8b81bce75..c370c3fd80bd80f50786c61d75c551cf3bada49f 100644
--- a/components/sync_driver/generic_change_processor.h
+++ b/components/sync_driver/generic_change_processor.h
@@ -114,7 +114,7 @@ class GenericChangeProcessor : public ChangeProcessor,
const std::string& type_str,
const syncer::WriteTransaction& trans,
syncer::WriteNode* sync_node,
- syncer::AttachmentIdList* new_attachments);
+ syncer::AttachmentIdSet* new_attachments);
// Logically part of ProcessSyncChanges.
//
@@ -125,13 +125,11 @@ class GenericChangeProcessor : public ChangeProcessor,
const std::string& type_str,
const syncer::WriteTransaction& trans,
syncer::WriteNode* sync_node,
- syncer::AttachmentIdList* new_attachments);
+ syncer::AttachmentIdSet* new_attachments);
- // Upload |attachments| to the sync server.
- //
- // This function assumes that attachments were already stored in
- // AttachmentStore.
- void UploadAttachments(const syncer::AttachmentIdList& attachment_ids);
+ // Begin uploading attachments that have not yet been uploaded to the sync
+ // server.
+ void UploadAllAttachmentsNotOnServer();
const syncer::ModelType type_;
« no previous file with comments | « no previous file | components/sync_driver/generic_change_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698