Make GenericChangeProcessor upload attachments on startup.

components/sync_driver/generic_change_processor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_
 #define COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 96 matching lines @@
 
  private:
   // Logically part of ProcessSyncChanges.
   //
   // |new_attachments| is an output parameter containing newly added attachments
   // that need to be stored.  This method will append to it.
   syncer::SyncError HandleActionAdd(const syncer::SyncChange& change,
                                     const std::string& type_str,
                                     const syncer::WriteTransaction& trans,
                                     syncer::WriteNode* sync_node,
-                                    syncer::AttachmentIdList* new_attachments);
+                                    syncer::AttachmentIdSet* new_attachments);
 
   // Logically part of ProcessSyncChanges.
   //
   // |new_attachments| is an output parameter containing newly added attachments
   // that need to be stored.  This method will append to it.
   syncer::SyncError HandleActionUpdate(
       const syncer::SyncChange& change,
       const std::string& type_str,
       const syncer::WriteTransaction& trans,
       syncer::WriteNode* sync_node,
-      syncer::AttachmentIdList* new_attachments);
+      syncer::AttachmentIdSet* new_attachments);
 
-  // Upload |attachments| to the sync server.
-  //
-  // This function assumes that attachments were already stored in
-  // AttachmentStore.
-  void UploadAttachments(const syncer::AttachmentIdList& attachment_ids);
+  // Begin uploading attachments that have not yet been uploaded to the sync
+  // server.
+  void UploadAllAttachmentsNotOnServer();
 
   const syncer::ModelType type_;
 
   // The SyncableService this change processor will forward changes on to.
   const base::WeakPtr<syncer::SyncableService> local_service_;
 
   // A SyncMergeResult used to track the changes made during association. The
   // owner will invalidate the weak pointer when association is complete. While
   // the pointer is valid though, we increment it with any changes received
   // via ProcessSyncChanges.
@@ skipping 24 matching lines @@
   scoped_ptr<syncer::AttachmentServiceProxy> attachment_service_proxy_;
 
   base::WeakPtrFactory<GenericChangeProcessor> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GenericChangeProcessor);
 };
 
 }  // namespace sync_driver
 
 #endif  // COMPONENTS_SYNC_DRIVER_GENERIC_CHANGE_PROCESSOR_H_