Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 582913002: Make GenericChangeProcessor upload attachments on startup. (Closed)

Created:
6 years, 3 months ago by maniscalco
Modified:
6 years, 3 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make GenericChangeProcessor upload attachments on startup. Convert some uses of AttachmentIdList to AttachmentIdSet. Remove the no longer needed UploadAttachments method from GenericChangeProcessor. BUG=372622 Committed: https://crrev.com/72ad3c600a38cfa8e8f00cb22e5eddffaaf98a61 Cr-Commit-Position: refs/heads/master@{#295988}

Patch Set 1 #

Patch Set 2 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -26 lines) Patch
M components/sync_driver/generic_change_processor.h View 2 chunks +5 lines, -7 lines 0 comments Download
M components/sync_driver/generic_change_processor.cc View 8 chunks +17 lines, -15 lines 0 comments Download
M components/sync_driver/generic_change_processor_unittest.cc View 3 chunks +35 lines, -1 line 0 comments Download
M sync/api/attachments/README View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/read_transaction.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sync/internal_api/read_transaction.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M sync/syncable/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/directory.h View 3 chunks +14 lines, -0 lines 0 comments Download
M sync/syncable/directory.cc View 3 chunks +63 lines, -1 line 0 comments Download
M sync/syncable/directory_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maniscalco
Pavel, would you please review this change?
6 years, 3 months ago (2014-09-18 20:04:13 UTC) #2
pavely
lgtm
6 years, 3 months ago (2014-09-19 17:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582913002/20001
6 years, 3 months ago (2014-09-22 15:38:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8a359fd46f1b06edfb2e768aed714b1136a8ea25
6 years, 3 months ago (2014-09-22 16:38:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:38:53 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/72ad3c600a38cfa8e8f00cb22e5eddffaaf98a61
Cr-Commit-Position: refs/heads/master@{#295988}

Powered by Google App Engine
This is Rietveld 408576698