Save password infobar should only work on schemes on which the bubble does

chrome/browser/password_manager/chrome_password_manager_client.cc

Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 4e10e36222734b65fa73689df8d319098249b543..97ef8d3f3c18c68a6fbb19761de2ecc18e06870b 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -10,6 +10,7 @@
 #include "base/metrics/histogram.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
@@ -150,6 +151,14 @@ void ChromePasswordManagerClient::AutofillResultsComputed() {
 
 void ChromePasswordManagerClient::PromptUserToSavePassword(
     scoped_ptr<password_manager::PasswordFormManager> form_to_save) {
+  // Save password infobar and the password bubble prompts only in case of
+  // web scheme URLs and DO NOT prompt in case of URLs with schemes like file:

[vabr (Chromium), 2014/09/25 11:07:27]

optional nit: I think the patch set 2 version of this comment was actually
better.

Don't get me wrong, I do not object to the word "webby" in general. In the
special context of the browser test, where only file: scheme was tested, the use
of "webby" was confusing.

But here it was fine, because the code below makes it clear what it means, and
the comment was shorter. Also, right now it only has an incomplete list of
schemes, so it's not that much more precise (whereas in the test, saying 'file:'
was much more precise).

For similar reasons, you did not have to wipe out "webby" from the CL
description and other places. :) It was really just the one place I commented
on, where it needed to go away. Sorry for the confusion. :)

[Sunil Ratnu, 2014/09/25 11:39:40]

Done.

+  // and schemes like 'chrome-extension'

[vabr (Chromium), 2014/09/25 11:07:27]

nit: Whatever comment you choose, please end it with a full stop ('.'), as a
proper sentence.

[Sunil Ratnu, 2014/09/25 11:39:40]

Done.

+  if (!BrowsingDataHelper::IsWebScheme(
+      web_contents()->GetLastCommittedURL().scheme())) {
+    return;
+  }
+
   if (IsTheHotNewBubbleUIEnabled()) {
     ManagePasswordsUIController* manage_passwords_ui_controller =
         ManagePasswordsUIController::FromWebContents(web_contents());