OLD | NEW |
---|---|
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" | 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" |
6 | 6 |
7 #include "base/bind_helpers.h" | 7 #include "base/bind_helpers.h" |
8 #include "base/command_line.h" | 8 #include "base/command_line.h" |
9 #include "base/memory/singleton.h" | 9 #include "base/memory/singleton.h" |
10 #include "base/metrics/histogram.h" | 10 #include "base/metrics/histogram.h" |
11 #include "base/strings/string16.h" | 11 #include "base/strings/string16.h" |
12 #include "base/strings/utf_string_conversions.h" | 12 #include "base/strings/utf_string_conversions.h" |
13 #include "chrome/browser/browsing_data/browsing_data_helper.h" | |
13 #include "chrome/browser/password_manager/password_manager_util.h" | 14 #include "chrome/browser/password_manager/password_manager_util.h" |
14 #include "chrome/browser/password_manager/password_store_factory.h" | 15 #include "chrome/browser/password_manager/password_store_factory.h" |
15 #include "chrome/browser/password_manager/save_password_infobar_delegate.h" | 16 #include "chrome/browser/password_manager/save_password_infobar_delegate.h" |
16 #include "chrome/browser/password_manager/sync_metrics.h" | 17 #include "chrome/browser/password_manager/sync_metrics.h" |
17 #include "chrome/browser/profiles/profile.h" | 18 #include "chrome/browser/profiles/profile.h" |
18 #include "chrome/browser/sync/profile_sync_service.h" | 19 #include "chrome/browser/sync/profile_sync_service.h" |
19 #include "chrome/browser/sync/profile_sync_service_factory.h" | 20 #include "chrome/browser/sync/profile_sync_service_factory.h" |
20 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h " | 21 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h " |
21 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" | 22 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" |
22 #include "chrome/common/chrome_switches.h" | 23 #include "chrome/common/chrome_switches.h" |
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
143 } | 144 } |
144 | 145 |
145 void ChromePasswordManagerClient::AutofillResultsComputed() { | 146 void ChromePasswordManagerClient::AutofillResultsComputed() { |
146 UMA_HISTOGRAM_BOOLEAN("PasswordManager.SyncCredentialFiltered", | 147 UMA_HISTOGRAM_BOOLEAN("PasswordManager.SyncCredentialFiltered", |
147 sync_credential_was_filtered_); | 148 sync_credential_was_filtered_); |
148 sync_credential_was_filtered_ = false; | 149 sync_credential_was_filtered_ = false; |
149 } | 150 } |
150 | 151 |
151 void ChromePasswordManagerClient::PromptUserToSavePassword( | 152 void ChromePasswordManagerClient::PromptUserToSavePassword( |
152 scoped_ptr<password_manager::PasswordFormManager> form_to_save) { | 153 scoped_ptr<password_manager::PasswordFormManager> form_to_save) { |
154 // Save password infobar and the password bubble prompts only in case of | |
155 // web scheme URLs and DO NOT prompt in case of URLs with schemes like file: | |
vabr (Chromium)
2014/09/25 11:07:27
optional nit: I think the patch set 2 version of t
Sunil Ratnu
2014/09/25 11:39:40
Done.
| |
156 // and schemes like 'chrome-extension' | |
vabr (Chromium)
2014/09/25 11:07:27
nit: Whatever comment you choose, please end it wi
Sunil Ratnu
2014/09/25 11:39:40
Done.
| |
157 if (!BrowsingDataHelper::IsWebScheme( | |
158 web_contents()->GetLastCommittedURL().scheme())) { | |
159 return; | |
160 } | |
161 | |
153 if (IsTheHotNewBubbleUIEnabled()) { | 162 if (IsTheHotNewBubbleUIEnabled()) { |
154 ManagePasswordsUIController* manage_passwords_ui_controller = | 163 ManagePasswordsUIController* manage_passwords_ui_controller = |
155 ManagePasswordsUIController::FromWebContents(web_contents()); | 164 ManagePasswordsUIController::FromWebContents(web_contents()); |
156 manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass()); | 165 manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass()); |
157 } else { | 166 } else { |
158 std::string uma_histogram_suffix( | 167 std::string uma_histogram_suffix( |
159 password_manager::metrics_util::GroupIdToString( | 168 password_manager::metrics_util::GroupIdToString( |
160 password_manager::metrics_util::MonitoredDomainGroupId( | 169 password_manager::metrics_util::MonitoredDomainGroupId( |
161 form_to_save->realm(), GetPrefs()))); | 170 form_to_save->realm(), GetPrefs()))); |
162 SavePasswordInfoBarDelegate::Create( | 171 SavePasswordInfoBarDelegate::Create( |
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
542 | 551 |
543 if (group_name == "DisallowSyncCredentialsForReauth") { | 552 if (group_name == "DisallowSyncCredentialsForReauth") { |
544 autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH; | 553 autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH; |
545 } else if (group_name == "DisallowSyncCredentials") { | 554 } else if (group_name == "DisallowSyncCredentials") { |
546 autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS; | 555 autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS; |
547 } else { | 556 } else { |
548 // Allow by default. | 557 // Allow by default. |
549 autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS; | 558 autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS; |
550 } | 559 } |
551 } | 560 } |
OLD | NEW |