Don't minimize dragged window when shelf hidden.

Don't minimize dragged window when shelf hidden.

If the shelf hides we should not immediately minimize a dragged panel. This panel can be dropped where it now is and detached.

BUG=393047
TEST=PanelWindowResizerTest.DetachThenHideShelf
TEST=Drag a panel window while switching profiles. There is no crash and the window is detached where it was when switching back.

Committed: https://crrev.com/35afaeb4f1498aaaa69ecb6c776c70b4c78bc4b6
Cr-Commit-Position: refs/heads/master@{#295711}

[flackr, 2014-09-18 17:45:51]

flackr@chromium.org changed reviewers:
+ skuhne@chromium.org

[flackr, 2014-09-18 17:45:51]

PTAL, thanks! The reason for the crash is described in the bug, but in fixing it
I also noticed that it would minimize the dragged panel which didn't match my
expectation so I've updated it to let it be dropped in it's current position.

Note, currently we do not cancel the drag on the profile switch, however we have
the same behavior with regular windows. We should probably update
TopLevelWindowEventHandler to complete a drag before the switch, but the panel
drag no longer causes a crash.

[Mr4D (OOO till 08-26), 2014-09-18 23:39:00]

Please address comments first.

lgtm

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
File ash/wm/panels/panel_window_resizer_unittest.cc (right):

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
ash/wm/panels/panel_window_resizer_unittest.cc:275: 
Could you please add a comment for this test? You might want to mention the
crbug

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
ash/wm/panels/panel_window_resizer_unittest.cc:300: // to.
This sentence is odd.

When the drag ends, the window should be detached and placed where it was
dragged to.

Or not?

[flackr, 2014-09-19 14:17:06]

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
File ash/wm/panels/panel_window_resizer_unittest.cc (right):

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
ash/wm/panels/panel_window_resizer_unittest.cc:275: 
On 2014/09/18 23:39:00, Mr4D wrote:
> Could you please add a comment for this test? You might want to mention the
> crbug

Done.

https://codereview.chromium.org/582803002/diff/1/ash/wm/panels/panel_window_r...
ash/wm/panels/panel_window_resizer_unittest.cc:300: // to.
On 2014/09/18 23:39:00, Mr4D wrote:
> This sentence is odd.
> 
> When the drag ends, the window should be detached and placed where it was
> dragged to.
> 
> Or not?

Done.

[flackr, 2014-09-19 14:17:34]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-09-19 14:17:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582803002/20001

[commit-bot: I haz the power, 2014-09-19 15:13:26]

Committed patchset #2 (id:20001) as 46b9034566d0c6f8d93b8c2893945aef8e096037

[commit-bot: I haz the power, 2014-09-19 15:14:03]

Patchset 2 (id:??) landed as
https://crrev.com/35afaeb4f1498aaaa69ecb6c776c70b4c78bc4b6
Cr-Commit-Position: refs/heads/master@{#295711}