Don't minimize dragged window when shelf hidden.

ash/wm/panels/panel_window_resizer_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_window_resizer.h"
 
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_model.h"
@@ skipping 254 matching lines @@
 TEST_F(PanelWindowResizerTest, PanelDetachReattachTop) {
  if (!SupportsHostWindowResize())
     return;
 
   ash::Shell* shell = ash::Shell::GetInstance();
   shell->SetShelfAlignment(SHELF_ALIGNMENT_TOP, shell->GetPrimaryRootWindow());
   scoped_ptr<aura::Window> window(
       CreatePanelWindow(gfx::Point(0, 0)));
   DetachReattachTest(window.get(), 0, 1);
 }
 

[Mr4D (OOO till 08-26), 2014/09/18 23:39:00]

Could you please add a comment for this test? You might want to mention the
crbug

[flackr, 2014/09/19 14:17:06]

Done.

+TEST_F(PanelWindowResizerTest, DetachThenHideShelf) {
+  if (!SupportsHostWindowResize())
+    return;
+  scoped_ptr<aura::Window> window(
+      CreatePanelWindow(gfx::Point(0, 0)));
+  wm::WindowState* state = wm::GetWindowState(window.get());
+  gfx::Rect expected_bounds = window->GetBoundsInScreen();
+  expected_bounds.set_y(expected_bounds.y() - 100);
+  DragStart(window.get());
+  DragMove(0, -100);
+  EXPECT_FALSE(state->IsMinimized());
+
+  // Hide the shelf. This minimizes all attached windows but should ignore
+  // the dragged window.
+  ShelfLayoutManager* shelf = RootWindowController::ForWindow(window.get())->
+      shelf()->shelf_layout_manager();
+  shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
+  shelf->UpdateVisibilityState();
+  RunAllPendingInMessageLoop();
+  EXPECT_FALSE(state->IsMinimized());
+  EXPECT_EQ(kShellWindowId_PanelContainer, window->parent()->id());
+  DragEnd();
+
+  // When the drag ends the window should be detached and where it was dragged
+  // to.

[Mr4D (OOO till 08-26), 2014/09/18 23:39:00]

This sentence is odd.

When the drag ends, the window should be detached and placed where it was
dragged to.

Or not?

[flackr, 2014/09/19 14:17:06]

Done.

+  EXPECT_EQ(kShellWindowId_DefaultContainer, window->parent()->id());
+  EXPECT_FALSE(state->IsMinimized());
+  EXPECT_EQ(expected_bounds.ToString(), window->GetBoundsInScreen().ToString());
+}
+
 TEST_F(PanelWindowResizerTest, PanelDetachReattachMultipleDisplays) {
   if (!SupportsMultipleDisplays())
     return;
 
   UpdateDisplay("600x400,600x400");
   aura::Window::Windows root_windows = Shell::GetAllRootWindows();
   scoped_ptr<aura::Window> window(
       CreatePanelWindow(gfx::Point(600, 0)));
   EXPECT_EQ(root_windows[1], window->GetRootWindow());
   DetachReattachTest(window.get(), 0, -1);
@@ skipping 268 matching lines @@
 
 INSTANTIATE_TEST_CASE_P(LtrRtl, PanelWindowResizerTextDirectionTest,
                         testing::Bool());
 INSTANTIATE_TEST_CASE_P(NormalPanelPopup,
                         PanelWindowResizerTransientTest,
                         testing::Values(ui::wm::WINDOW_TYPE_NORMAL,
                                         ui::wm::WINDOW_TYPE_PANEL,
                                         ui::wm::WINDOW_TYPE_POPUP));
 
 }  // namespace ash