Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 582633003: Reduce overdraw in MultiPictureDraw Sierpinski GM (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Reduce overdraw in MultiPictureDraw Sierpinski GM As written, all the layers in the MPD Sierpinski GM are full screen. This CL bounds each layer to reduce overdraw. This CL will cause differences in: multipicturedraw_sierpinski_simple multipicturedraw_sierpinski_tiled but they are/will be suppressed in: (Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/) Committed: https://skia.googlesource.com/skia/+/7f1ed835e90027f63fbb25d19fb71d128b13834d

Patch Set 1 #

Patch Set 2 : Update patch for GM changes (i.e., translate) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gm/multipicturedraw.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
6 years, 3 months ago (2014-09-19 21:32:01 UTC) #2
bsalomon
On 2014/09/19 21:32:01, robertphillips wrote: why does this fix the bug?
6 years, 3 months ago (2014-09-22 14:25:36 UTC) #3
robertphillips
PTAL. (Don't turn on dither for saveLayers which have no paint - https://codereview.chromium.org/619363002/) fixes the ...
6 years, 2 months ago (2014-10-03 12:35:29 UTC) #4
bsalomon
lgtm
6 years, 2 months ago (2014-10-03 13:25:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582633003/20001
6 years, 2 months ago (2014-10-03 13:54:19 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 14:29:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 7f1ed835e90027f63fbb25d19fb71d128b13834d

Powered by Google App Engine
This is Rietveld 408576698