Enable accessibility testing for the bookmark browser test.

chrome/test/base/in_process_browser_test.h

Index: chrome/test/base/in_process_browser_test.h
diff --git a/chrome/test/base/in_process_browser_test.h b/chrome/test/base/in_process_browser_test.h
index 07710d2743a09f7e4cd643ef36e46d2969a5358a..e4727cb6ae7260d5c8d6a90ab3023069073f7551 100644
--- a/chrome/test/base/in_process_browser_test.h
+++ b/chrome/test/base/in_process_browser_test.h
@@ -148,6 +148,16 @@ class InProcessBrowserTest : public content::BrowserTestBase {
   // the navigation to complete, and show the browser's window.
   void AddBlankTabAndShow(Browser* browser);
 
+  // Disables running of accessibility tests for a particular test case. This is

[Paweł Hajdan Jr., 2015/01/29 13:01:19]

Do we really need this somewhat elaborate from API POV way to disable checks
either for all test cases or just for a specific one? This doesn't seem used.

Actually if one wants to disable checks for all test cases
DisableAccessibilityChecks could be called from SetUp() method.

[hcarmona, 2015/01/30 22:19:47]

This is based on the a11y audit from js: src/chrome/test/data/webui/test_api.js
I added the ability to set a class level ON/OFF and test level ON/OFF in order
to mirror that API.

I am not opposed to simplifying the interface, but I feel that having these
methods makes the user's intentions more explicit. If we want to simplify the
API, we can get rid of set_run_accessibility_checks but I think it makes sense
to keep both EnableA11yChecks and DisableA11yChecks so that all checks can be
enabled in SetUp but individual tests can still be disabled. I have seen cases
where all tests in a test suite will pass the a11y audit except for one, but it
can't be fixed immediately for some reason (3rd party lib). In those cases it is
necessary to disable just one test.

+  // only meaningful when called from IN_PROC_BROWSER_TEST_F to override the
+  // value of run_accessibility_checks_.
+  void DisableAccessibilityChecks();
+
+  // Enables running of accessibility tests for a particular test case. This is
+  // only meaningful when called from IN_PROC_BROWSER_TEST_F to override the
+  // value of run_accessibility_checks_.
+  void EnableAccessibilityChecks();
+
 #if !defined OS_MACOSX
   // Return a CommandLine object that is used to relaunch the browser_test
   // binary as a browser process. This function is deliberately not defined on
@@ -178,6 +188,12 @@ class InProcessBrowserTest : public content::BrowserTestBase {
     multi_desktop_test_ = multi_desktop_test;
   }
 
+  // This should be called in a sub-class constructor to enable/disable
+  // accessibility testing for all test cases.
+  void set_run_accessibility_checks(bool run_accessibility_checks) {
+    run_accessibility_checks_ = run_accessibility_checks;
+  }
+
  private:
   // Creates a user data directory for the test if one is needed. Returns true
   // if successful.
@@ -190,6 +206,9 @@ class InProcessBrowserTest : public content::BrowserTestBase {
   // with an in-process test.
   void PrepareTestCommandLine(base::CommandLine* command_line);
 
+  // Will run accessibility checks and fail the test if there are any issues.
+  void RunAccessibilityChecks();
+
   // Browser created from CreateBrowser.
   Browser* browser_;
 
@@ -207,6 +226,13 @@ class InProcessBrowserTest : public content::BrowserTestBase {
   // not ensure that Browsers are only created on the tested desktop).
   bool multi_desktop_test_;
 
+  // True if the accessibility tests should be run.
+  bool run_accessibility_checks_;
+
+  // True if the accessibility test should run for a particular test case.
+  // This is reset for every test case.
+  bool run_accessibility_checks_for_test_case_;
+
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
 #endif  // OS_MACOSX