Enable accessibility testing for the bookmark browser test.

chrome/test/base/in_process_browser_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 #define CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 
 #include "base/compiler_specific.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
@@ skipping 130 matching lines @@
   Browser* CreateBrowserForPopup(Profile* profile);
 
   // Creates a browser for an application and waits for it to load and shows
   // the browser.
   Browser* CreateBrowserForApp(const std::string& app_name, Profile* profile);
 
   // Called from the various CreateBrowser methods to add a blank tab, wait for
   // the navigation to complete, and show the browser's window.
   void AddBlankTabAndShow(Browser* browser);
 
+  // Disables running of accessibility tests for a particular test case. This is

[Paweł Hajdan Jr., 2015/01/29 13:01:19]

Do we really need this somewhat elaborate from API POV way to disable checks
either for all test cases or just for a specific one? This doesn't seem used.

Actually if one wants to disable checks for all test cases
DisableAccessibilityChecks could be called from SetUp() method.

[hcarmona, 2015/01/30 22:19:47]

This is based on the a11y audit from js: src/chrome/test/data/webui/test_api.js
I added the ability to set a class level ON/OFF and test level ON/OFF in order
to mirror that API.

I am not opposed to simplifying the interface, but I feel that having these
methods makes the user's intentions more explicit. If we want to simplify the
API, we can get rid of set_run_accessibility_checks but I think it makes sense
to keep both EnableA11yChecks and DisableA11yChecks so that all checks can be
enabled in SetUp but individual tests can still be disabled. I have seen cases
where all tests in a test suite will pass the a11y audit except for one, but it
can't be fixed immediately for some reason (3rd party lib). In those cases it is
necessary to disable just one test.

+  // only meaningful when called from IN_PROC_BROWSER_TEST_F to override the
+  // value of run_accessibility_checks_.
+  void DisableAccessibilityChecks();
+
+  // Enables running of accessibility tests for a particular test case. This is
+  // only meaningful when called from IN_PROC_BROWSER_TEST_F to override the
+  // value of run_accessibility_checks_.
+  void EnableAccessibilityChecks();
+
 #if !defined OS_MACOSX
   // Return a CommandLine object that is used to relaunch the browser_test
   // binary as a browser process. This function is deliberately not defined on
   // the Mac because re-using an existing browser process when launching from
   // the command line isn't a concept that we support on the Mac; AppleEvents
   // are the Mac solution for the same need. Any test based on these functions
   // doesn't apply to the Mac.
   base::CommandLine GetCommandLineForRelaunch();
 #endif
 
@@ skipping 10 matching lines @@
 
   void set_open_about_blank_on_browser_launch(bool value) {
     open_about_blank_on_browser_launch_ = value;
   }
 
   // This must be called before RunTestOnMainThreadLoop() to have any effect.
   void set_multi_desktop_test(bool multi_desktop_test) {
     multi_desktop_test_ = multi_desktop_test;
   }
 
+  // This should be called in a sub-class constructor to enable/disable
+  // accessibility testing for all test cases.
+  void set_run_accessibility_checks(bool run_accessibility_checks) {
+    run_accessibility_checks_ = run_accessibility_checks;
+  }
+
  private:
   // Creates a user data directory for the test if one is needed. Returns true
   // if successful.
   virtual bool CreateUserDataDirectory() WARN_UNUSED_RESULT;
 
   // Quits all open browsers and waits until there are no more browsers.
   void QuitBrowsers();
 
   // Prepare command line that will be used to launch the child browser process
   // with an in-process test.
   void PrepareTestCommandLine(base::CommandLine* command_line);
 
+  // Will run accessibility checks and fail the test if there are any issues.
+  void RunAccessibilityChecks();
+
   // Browser created from CreateBrowser.
   Browser* browser_;
 
   // Temporary user data directory. Used only when a user data directory is not
   // specified in the command line.
   base::ScopedTempDir temp_user_data_dir_;
 
   // True if we should exit the tests after the last browser instance closes.
   bool exit_when_last_browser_closes_;
 
   // True if the about:blank tab should be opened when the browser is launched.
   bool open_about_blank_on_browser_launch_;
 
   // True if this is a multi-desktop test (in which case this browser test will
   // not ensure that Browsers are only created on the tested desktop).
   bool multi_desktop_test_;
 
+  // True if the accessibility tests should be run.
+  bool run_accessibility_checks_;
+
+  // True if the accessibility test should run for a particular test case.
+  // This is reset for every test case.
+  bool run_accessibility_checks_for_test_case_;
+
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
 #endif  // OS_MACOSX
 
 #if defined(OS_WIN)
   scoped_ptr<base::win::ScopedCOMInitializer> com_initializer_;
 #endif
 };
 
 #endif  // CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_