Safebrowsing: Fix failure parsing a gethash result with bad listname and metadata.

Safebrowsing: Fix failure parsing a gethash result with bad listname and metadata.

BUG=415705
Committed: https://crrev.com/5a695b36e330cf3a67633eee5e7d0901e9330c56
Cr-Commit-Position: refs/heads/master@{#295576}

[mattm, 2014-09-18 19:57:03]

Patchset #1 (id:1) has been deleted

[mattm, 2014-09-18 19:57:08]

Patchset #1 (id:20001) has been deleted

[mattm, 2014-09-18 19:57:40]

mattm@chromium.org changed reviewers:
+ noelutz@chromium.org

[noé, 2014-09-18 20:41:08]

lgtm

Thanks for the quick fix.  Can we get that merged into M37?

https://codereview.chromium.org/582143002/diff/40001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/protocol_parser.cc (right):

https://codereview.chromium.org/582143002/diff/40001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/protocol_parser.cc:226: if (has_metadata &&
!ParseGetHashMetadata(hash_count, &reader))
nit: can you add a TODO here to send the metadata back to the client that
triggered the gethash?  This information should be used to know which malware
interstitial to show (distribution vs. landing).

[mattm, 2014-09-18 20:50:32]

On 2014/09/18 20:41:08, noé wrote:
> lgtm
> 
> Thanks for the quick fix.  Can we get that merged into M37?

Dunno if 37 is still accepting merges, but I'll see.

https://codereview.chromium.org/582143002/diff/40001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/protocol_parser.cc (right):

https://codereview.chromium.org/582143002/diff/40001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/protocol_parser.cc:226: if (has_metadata &&
!ParseGetHashMetadata(hash_count, &reader))
On 2014/09/18 20:41:07, noé wrote:
> nit: can you add a TODO here to send the metadata back to the client that
> triggered the gethash?  This information should be used to know which malware
> interstitial to show (distribution vs. landing).

Done. 

I need to pull that out of my old api 2.3 WIP cl and update it...

[mattm, 2014-09-18 20:54:57]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-09-18 20:56:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582143002/60001

[commit-bot: I haz the power, 2014-09-18 22:05:38]

Committed patchset #2 (id:60001) as 4495c019da56e8dda39c32f67442190d67026926

[commit-bot: I haz the power, 2014-09-18 22:06:29]

Patchset 2 (id:??) landed as
https://crrev.com/5a695b36e330cf3a67633eee5e7d0901e9330c56
Cr-Commit-Position: refs/heads/master@{#295576}