Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: chrome/browser/safe_browsing/protocol_parser_unittest.cc

Issue 582143002: Safebrowsing: Fix failure parsing a gethash result with bad listname and metadata. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add todo Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/protocol_parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/protocol_parser_unittest.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser_unittest.cc b/chrome/browser/safe_browsing/protocol_parser_unittest.cc
index f67bd3828fa06bb843ddf0c3d1cdf8ed356f879a..cf8cd7b59e4af09d1a4c603eda73c5745e893bd6 100644
--- a/chrome/browser/safe_browsing/protocol_parser_unittest.cc
+++ b/chrome/browser/safe_browsing/protocol_parser_unittest.cc
@@ -508,6 +508,28 @@ TEST(SafeBrowsingProtocolParsingTest, TestGetHashWithUnknownList) {
EXPECT_EQ(safe_browsing_util::MALWARE, full_hashes[1].list_id);
}
+TEST(SafeBrowsingProtocolParsingTest, TestGetHashWithUnknownListAndMetadata) {
+ std::vector<SBFullHashResult> full_hashes;
+ base::TimeDelta cache_lifetime;
+ // Test skipping over a hashentry with an unrecognized listname that also has
+ // metadata.
+ const std::string get_hash3(base::StringPrintf(
+ "600\n"
+ "BADLISTNAME:32:1:m\n"
+ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
+ "8\nMETADATA"
+ "%s:32:1\n"
+ "0123456789hashhashhashhashhashha",
+ kDefaultMalwareList));
+ EXPECT_TRUE(safe_browsing::ParseGetHash(get_hash3.data(), get_hash3.length(),
+ &cache_lifetime, &full_hashes));
+ ASSERT_EQ(1U, full_hashes.size());
+ EXPECT_EQ(memcmp(&full_hashes[0].hash,
+ "0123456789hashhashhashhashhashha",
+ sizeof(SBFullHash)), 0);
+ EXPECT_EQ(safe_browsing_util::MALWARE, full_hashes[0].list_id);
+}
+
TEST(SafeBrowsingProtocolParsingTest, TestFormatHash) {
std::vector<SBPrefix> prefixes;
prefixes.push_back(0x34333231);
« no previous file with comments | « chrome/browser/safe_browsing/protocol_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698