Move FindFullName outside LIBPEERCONNECTION_LIB definition block. This is to solve a link break whe…

Move FindFullName outside LIBPEERCONNECTION_LIB definition block. This is to solve a link break when new finch experiment is defined inside peerconnection.cc while libpeerconnection.so is built as a shared library.

BUG=

Committed: https://crrev.com/b35d075d92b70680c815ba0787215aceb695d0b0
Cr-Commit-Position: refs/heads/master@{#295758}

[guoweis2, 2014-09-18 19:32:25]

guoweis@google.com changed reviewers:
+ andresp@chromium.org, guoweis@google.com

[andresp-chromium, 2014-09-18 20:17:07]

On 2014/09/18 19:32:25, guoweis2 wrote:

lgtm

[guoweis2, 2014-09-18 20:17:48]

On 2014/09/18 20:17:07, andresp wrote:
> On 2014/09/18 19:32:25, guoweis2 wrote:
> 
> lgtm

@sergeyu: please OWNER review this change.

[guoweis2, 2014-09-18 20:18:16]

guoweis@google.com changed reviewers:
+ sergeyu@chromium.org

[guoweis2, 2014-09-18 20:18:17]

@sergeyu, please OWNER review this change.

[guoweis2, 2014-09-18 20:18:18]

@sergeyu, please OWNER review this change.

[guoweis2, 2014-09-18 20:29:49]

On 2014/09/18 20:18:18, guoweis2 wrote:
> @sergeyu, please OWNER review this change.

Here is the context.

An internal link build break was introduced when adding new finch experiment in
peerconnection.cc. 

Peerconnection.cc is part of libjingle_webrtc_common and used by both
libpeerconnection.so as well as chrome. (many components seem to have the same
pattern).

Inside init_webrtc.cc, depending on the LIBPEERCONNECTION_LIB definition,
field_trials::FindFullName will either be defined (in the case of a static lib)
or just reference to the global base::FindFullName (and pass that function as
pointer to libpeerconnection.so where it does have field_trials::FindFullName
defined).

Now the new finch inside peerconnection.cc also needs field_trials::FindFullName
but due to this flag, init_webrtc.cc doesn't have it, hence chrome linkage
broke.

[Sergey Ulanov, 2014-09-19 18:40:11]

lgtm

[guoweis2, 2014-09-19 18:49:00]

The CQ bit was checked by guoweis@google.com

[commit-bot: I haz the power, 2014-09-19 18:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582133002/1

[commit-bot: I haz the power, 2014-09-19 19:18:50]

Committed patchset #1 (id:1) as 29ec65b25ac1f63218b791094dec2d7d18b93adf

[commit-bot: I haz the power, 2014-09-19 19:19:27]

Patchset 1 (id:??) landed as
https://crrev.com/b35d075d92b70680c815ba0787215aceb695d0b0
Cr-Commit-Position: refs/heads/master@{#295758}