Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/libjingle/overrides/init_webrtc.cc

Issue 582133002: Move FindFullName outside LIBPEERCONNECTION_LIB definition block. This is to solve a link break whe… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libjingle/overrides/init_webrtc.cc
diff --git a/third_party/libjingle/overrides/init_webrtc.cc b/third_party/libjingle/overrides/init_webrtc.cc
index e11f78d183c90edac486658d8c41e15eb9808cec..4a2fe73bd6a3ff2132d1a509bb518f12077498da 100644
--- a/third_party/libjingle/overrides/init_webrtc.cc
+++ b/third_party/libjingle/overrides/init_webrtc.cc
@@ -32,6 +32,16 @@ void AddTraceEvent(char phase,
NULL, flags);
}
+// Define webrtc:field_trial::FindFullName to provide webrtc with a field trial
+// implementation.
+namespace webrtc {
+namespace field_trial {
+std::string FindFullName(const std::string& trial_name) {
+ return base::FieldTrialList::FindFullName(trial_name);
+}
+} // namespace field_trial
+} // namespace webrtc
+
#if defined(LIBPEERCONNECTION_LIB)
// libpeerconnection is being compiled as a static lib. In this case
@@ -43,17 +53,6 @@ bool InitializeWebRtcModule() {
return true;
}
-// Define webrtc:field_trial::FindFullName to provide webrtc with a field trial
-// implementation. When compiled as a static library this can be done directly
-// and without pointers to functions.
-namespace webrtc {
-namespace field_trial {
-std::string FindFullName(const std::string& trial_name) {
- return base::FieldTrialList::FindFullName(trial_name);
-}
-} // namespace field_trial
-} // namespace webrtc
-
#else // !LIBPEERCONNECTION_LIB
// When being compiled as a shared library, we need to bridge the gap between
@@ -127,13 +126,16 @@ bool InitializeWebRtcModule() {
InitDiagnosticLoggingDelegateFunctionFunction init_diagnostic_logging = NULL;
bool init_ok = initialize_module(*CommandLine::ForCurrentProcess(),
#if !defined(OS_MACOSX) && !defined(OS_ANDROID)
- &Allocate, &Dellocate,
+ &Allocate,
+ &Dellocate,
#endif
- &base::FieldTrialList::FindFullName,
- logging::GetLogMessageHandler(),
- &GetCategoryGroupEnabled, &AddTraceEvent,
- &g_create_webrtc_media_engine, &g_destroy_webrtc_media_engine,
- &init_diagnostic_logging);
+ &webrtc::field_trial::FindFullName,
+ logging::GetLogMessageHandler(),
+ &GetCategoryGroupEnabled,
+ &AddTraceEvent,
+ &g_create_webrtc_media_engine,
+ &g_destroy_webrtc_media_engine,
+ &init_diagnostic_logging);
if (init_ok)
rtc::SetExtraLoggingInit(init_diagnostic_logging);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698