Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1920)

Unified Diff: pkg/polymer/lib/src/events.dart

Issue 582113002: fix findController for non-dart elements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: update pubspec/changelog Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/CHANGELOG.md ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/events.dart
diff --git a/pkg/polymer/lib/src/events.dart b/pkg/polymer/lib/src/events.dart
index 881728a65c80619c0f5b6ff4d7480956229d3b5a..33905c1c4985e08dc9473707399f810c1978435e 100644
--- a/pkg/polymer/lib/src/events.dart
+++ b/pkg/polymer/lib/src/events.dart
@@ -52,6 +52,12 @@ abstract class PolymerEventBindings {
while (node.parentNode != null) {
if (node is Polymer && node.eventController != null) {
return node.eventController;
+ } else if (node.nodeName.contains('-')){
Siggi Cherem (dart-lang) 2014/09/18 18:10:58 as we discussed, let's switch to: - check is Elem
jakemac 2014/09/18 18:17:07 Done.
+ // Looks like a custom node, but not a dart one. Try getting the
+ // eventController through js interop.
+ var eventController =
+ new JsObject.fromBrowserObject(node)['eventController'];
+ if (eventController != null) return eventController;
}
node = node.parentNode;
}
« no previous file with comments | « pkg/polymer/CHANGELOG.md ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698