Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 582113002: fix findController for non-dart elements (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update pubspec/changelog #

Total comments: 2

Patch Set 3 : check is attribute and add an Element check #

Patch Set 4 : support native elements, and add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -15 lines) Patch
M pkg/pkg.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/polymer/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/events.dart View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A pkg/polymer/test/event_controller_test.dart View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download
A + pkg/polymer/test/event_controller_test.html View 1 2 3 1 chunk +15 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jakemac
6 years, 3 months ago (2014-09-18 17:39:43 UTC) #2
Siggi Cherem (dart-lang)
great, I wonder if we should add a simple text (creating manually a couple JS ...
6 years, 3 months ago (2014-09-18 18:10:58 UTC) #3
jakemac
Will work on a test now https://codereview.chromium.org/582113002/diff/20001/pkg/polymer/lib/src/events.dart File pkg/polymer/lib/src/events.dart (right): https://codereview.chromium.org/582113002/diff/20001/pkg/polymer/lib/src/events.dart#newcode55 pkg/polymer/lib/src/events.dart:55: } else if ...
6 years, 3 months ago (2014-09-18 18:17:08 UTC) #4
jakemac
Test added, ptal
6 years, 3 months ago (2014-09-18 20:03:34 UTC) #5
Siggi Cherem (dart-lang)
lgtm
6 years, 3 months ago (2014-09-18 20:14:42 UTC) #6
jakemac
6 years, 3 months ago (2014-09-18 20:31:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 40458 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698