Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index f1e43cc8073f7f134327efec8b8e4ed4d2ea5aed..d132fb383157e212825dfebe6860683e2a26e504 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -89,7 +89,6 @@ class ContentViewCoreImpl : public ContentViewCore,
base::android::ScopedJavaLocalRef<jstring> GetTitle(
JNIEnv* env, jobject obj) const;
jboolean IsIncognito(JNIEnv* env, jobject obj);
- jboolean Crashed(JNIEnv* env, jobject obj) const { return tab_crashed_; }
void SendOrientationChangeEvent(JNIEnv* env, jobject obj, jint orientation);
jboolean SendTouchEvent(JNIEnv* env,
jobject obj,
@@ -345,10 +344,6 @@ class ContentViewCoreImpl : public ContentViewCore,
void SendGestureEvent(const WebKit::WebGestureEvent& event);
- // Checks if there there is a corresponding renderer process and updates
- // |tab_crashed_| accordingly.
- void UpdateTabCrashedFlag();
-
// Update focus state of the RenderWidgetHostView.
void SetFocusInternal(bool focused);
@@ -367,9 +362,6 @@ class ContentViewCoreImpl : public ContentViewCore,
// A compositor layer containing any layer that should be shown.
scoped_refptr<cc::Layer> root_layer_;
- // Whether the renderer backing this ContentViewCore has crashed.
- bool tab_crashed_;
-
// Device scale factor.
float dpi_scale_;

Powered by Google App Engine
This is Rietveld 408576698