chrome/browser/guestview/webview/webview_guest.cc - Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guestview/webview/webview_guest.cc

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/process/kill.h ('k') | content/browser/android/child_process_launcher_android.h » ('j') | content/browser/android/web_contents_observer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guestview/webview/webview_guest.cc

diff --git a/chrome/browser/guestview/webview/webview_guest.cc b/chrome/browser/guestview/webview/webview_guest.cc

index d5c66fb66b6028d2bb77833c9d2f90d358626d4a..4d3fc50f0a4ca250d7883a9708a49e03394e6821 100644

--- a/chrome/browser/guestview/webview/webview_guest.cc

+++ b/chrome/browser/guestview/webview/webview_guest.cc

@@ -47,6 +47,7 @@ static std::string TerminationStatusToString(base::TerminationStatus status) {

case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:

return "killed";

case base::TERMINATION_STATUS_PROCESS_CRASHED:

+ case base::TERMINATION_STATUS_OOM_PROTECTED:

Yaron 2013/11/05 01:48:43 #if defined(OS_ANDROID) wouldn't compile otherwi

ppi 2013/11/05 13:58:18 Done (yup, this is http://developer.chrome.com/app

return "crashed";

case base::TERMINATION_STATUS_MAX_ENUM:

break;