Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 581963004: Clean up GestureEventDetails constructors and fix unit tests. (Closed)

Created:
6 years, 3 months ago by lanwei
Modified:
6 years, 3 months ago
Reviewers:
sky, tdresser
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, ben+aura_chromium.org, Ilya Sherman, tdanderson+views_chromium.org, benquan, jdduke+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, tdresser+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, tfarina, stevenjb+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up GestureEventDetails constructors and fix unit tests. Reland the code change for Issue 573963005: Clean up GestureEventDetails constructors and fix unit tests: https://codereview.chromium.org/573963005/. The code does not change, just merge two commits into one. BUG=350942 TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org Committed: https://crrev.com/46f76555938808dd916c4e2d5c0d7de1333a821d Cr-Commit-Position: refs/heads/master@{#295706}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -219 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/home/home_card_gesture_manager_unittest.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/browser/renderer_host/input/gesture_text_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_event_details.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/events/gesture_event_details.cc View 3 chunks +8 lines, -18 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 7 chunks +24 lines, -22 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 5 chunks +15 lines, -25 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/views/widget/root_view_unittest.cc View 6 chunks +18 lines, -36 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 8 chunks +26 lines, -32 lines 0 comments Download
M ui/wm/core/user_activity_detector_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581963004/20001
6 years, 3 months ago (2014-09-19 04:12:00 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 04:12:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581963004/20001
6 years, 3 months ago (2014-09-19 04:35:07 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 04:35:11 UTC) #9
lanwei
sky@, can you please review this issue again? They revert it by mistake, because they ...
6 years, 3 months ago (2014-09-19 04:39:28 UTC) #11
tdresser
On 2014/09/19 04:39:28, lanwei wrote: > sky@, can you please review this issue again? They ...
6 years, 3 months ago (2014-09-19 14:22:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581963004/20001
6 years, 3 months ago (2014-09-19 14:24:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001) as c8275a64567540d2ebb0797b5dee581df8777993
6 years, 3 months ago (2014-09-19 14:52:56 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:53:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46f76555938808dd916c4e2d5c0d7de1333a821d
Cr-Commit-Position: refs/heads/master@{#295706}

Powered by Google App Engine
This is Rietveld 408576698