Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 581963004: Clean up GestureEventDetails constructors and fix unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
index 370e4c7b0e6d512864d1af392d37743c17641560..c159d5f5272f9a639f05e8bec1f11046a83ca130 100644
--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
@@ -229,7 +229,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
10,
0,
ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
touch_editable->Reset();
rwhva->OnGestureEvent(&long_press);
touch_editable->WaitForSelectionChangeCallback();
@@ -249,7 +249,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
10,
0,
ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_BEGIN));
rwhva->OnGestureEvent(&scroll_begin);
EXPECT_FALSE(GetTouchSelectionController(touch_editable));
@@ -259,7 +259,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
10,
0,
ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_END, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_SCROLL_END));
rwhva->OnGestureEvent(&scroll_end);
EXPECT_TRUE(GetTouchSelectionController(touch_editable));
}
@@ -284,7 +284,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
10,
0,
ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
touch_editable->Reset();
rwhva->OnGestureEvent(&long_press);
touch_editable->WaitForSelectionChangeCallback();
@@ -340,7 +340,7 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
10,
0,
ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS, 0, 0));
+ ui::GestureEventDetails(ui::ET_GESTURE_LONG_PRESS));
touch_editable->Reset();
rwhva->OnGestureEvent(&long_press);
touch_editable->WaitForSelectionChangeCallback();
@@ -370,12 +370,9 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
EXPECT_EQ(GetRenderWidgetHostViewAura(touch_editable), rwhva);
// Double-tap to select word.
- ui::GestureEvent double_tap(
- 10,
- 10,
- 0,
- ui::EventTimeForNow(),
- ui::GestureEventDetails(ui::ET_GESTURE_TAP, 2, 0));
+ ui::GestureEventDetails details(ui::ET_GESTURE_TAP);
+ details.set_tap_count(2);
+ ui::GestureEvent double_tap(10, 10, 0, ui::EventTimeForNow(), details);
touch_editable->Reset();
rwhva->OnGestureEvent(&double_tap);
touch_editable->WaitForSelectionChangeCallback();
« no previous file with comments | « content/browser/renderer_host/input/gesture_text_selector_unittest.cc ('k') | ui/aura/remote_window_tree_host_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698