chrome/browser/ssl/ssl_blocking_page.cc - Issue 581803002: Component updater must fallback on using HTTP on Windows XPSP2 and below

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 581803002: Component updater must fallback on using HTTP on Windows XPSP2 and below (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/win/win_util.h ('K') | « chrome/browser/component_updater/chrome_component_updater_configurator.cc ('k') | chrome/browser/ssl/ssl_error_classification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_blocking_page.cc

diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc

index f9aa36ae16bf1acb50a0e50826c794f1437161ba..aaef20b4b4da1eac9ad8b05ca1bd55aa48d9984d 100644

--- a/chrome/browser/ssl/ssl_blocking_page.cc

+++ b/chrome/browser/ssl/ssl_blocking_page.cc

@@ -470,8 +470,8 @@ std::string SSLBlockingPage::GetHTMLContents() {

} else {

SSLErrorInfo::ErrorType type =

SSLErrorInfo::NetErrorToErrorType(cert_error_);

- if (type == SSLErrorInfo::CERT_INVALID && SSLErrorClassification::

- IsWindowsVersionSP3OrLower()) {

+ if (type == SSLErrorInfo::CERT_INVALID && !SSLErrorClassification::

+ MaybeWindowsHasSHA256Support()) {

waffles 2014/09/18 18:00:06 Both SSLErrorClassification::IsWindowsVersionSP3Or

Sorin Jianu 2014/09/18 18:22:23 Done.

load_time_data.SetString(

"explanationParagraph",

l10n_util::GetStringFUTF16(