Component updater must fallback on using HTTP on Windows XPSP2 and below

chrome/browser/ssl/ssl_blocking_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 
 #include "base/build_time.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/time_formatting.h"
@@ skipping 452 matching lines @@
     load_time_data.SetString(
         "primaryButtonText",
         l10n_util::GetStringUTF16(IDS_SSL_OVERRIDABLE_SAFETY_BUTTON));
     load_time_data.SetString(
         "finalParagraph",
         l10n_util::GetStringFUTF16(IDS_SSL_OVERRIDABLE_PROCEED_PARAGRAPH,
                                    url));
   } else {
     SSLErrorInfo::ErrorType type =
         SSLErrorInfo::NetErrorToErrorType(cert_error_);
-    if (type == SSLErrorInfo::CERT_INVALID && SSLErrorClassification::
-        IsWindowsVersionSP3OrLower()) {
+    if (type == SSLErrorInfo::CERT_INVALID && !SSLErrorClassification::
+        MaybeWindowsHasSHA256Support()) {

[waffles, 2014/09/18 18:00:06]

Both SSLErrorClassification::IsWindowsVersionSP3OrLower and
SSLErrorClassification::MaybeWindowsHasSHA256Support return false if you call
them not on Windows, but you introduced a "!" here. I believe this changes the
behavior for non-Windows.

In general, what does it mean to call
"SSLErrorClassification::MaybeWindowsHasSHA256Support" if you're not running
Windows? Maybe the function should just be "MaybeHasSHA256Support"?

[Sorin Jianu, 2014/09/18 18:22:23]

Done.

       load_time_data.SetString(
           "explanationParagraph",
           l10n_util::GetStringFUTF16(
               IDS_SSL_NONOVERRIDABLE_MORE_INVALID_SP3, url));
     } else if (bad_clock) {
       load_time_data.SetString("explanationParagraph",
                                l10n_util::GetStringFUTF16(
                                    IDS_SSL_CLOCK_ERROR_EXPLANATION, url));
     } else {
       load_time_data.SetString("explanationParagraph",
@@ skipping 168 matching lines @@
   for (; i < 5; i++) {
     strings->SetString(keys[i], std::string());
   }
 }
 
 void SSLBlockingPage::OnGotHistoryCount(bool success,
                                         int num_visits,
                                         base::Time first_visit) {
   num_visits_ = num_visits;
 }