Issue 581643005: Revert "cc: Use impl-side painting in LTH context lost tests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 581643005: Revert "cc: Use impl-side painting in LTH context lost tests." (Closed)

Created:
6 years, 3 months ago by Dirk Pranke

Modified:
6 years, 3 months ago

Reviewers:
danakj, sohanjg_

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "cc: Use impl-side painting in LTH context lost tests." This reverts commit fa27ef28c604c3bd343f7d8298ac3f328a9a0037. This caused LayerTreeHostContextTestLostContextAndEvictTextures. LoseBeforeEvict_MultiThread_DelegatingRenderer_ImplSidePaint to crash flakily. TBR=sohanjg@chromium.org, danakj@chromium.org BUG=401492 Committed: https://crrev.com/035a7945ae0e91709479b824e03a8903e2ed2af1 Cr-Commit-Position: refs/heads/master@{#295312}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -298 lines)			Patch
M	cc/test/fake_picture_layer.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	cc/test/fake_picture_layer.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	cc/test/fake_picture_layer_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	cc/test/fake_picture_layer_impl.cc	View	4 chunks	+3 lines, -11 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl_unittest.cc	View	18 chunks	+34 lines, -87 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_context.cc	View	19 chunks	+71 lines, -177 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Sample failure: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20(1)/builds/55792 (It was failing on other Mac bots as well).

6 years, 3 months ago (2014-09-17 18:57:05 UTC) #1

Dirk Pranke

Committed patchset #1 (id:1) manually as 035a794 (presubmit successful).

6 years, 3 months ago (2014-09-17 18:57:20 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-17 18:57:22 UTC) #3

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/035a7945ae0e91709479b824e03a8903e2ed2af1
Cr-Commit-Position: refs/heads/master@{#295312}

Expand Messages | Collapse Messages