Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 581463004: NonSFI mode: Add libcrt_platform for native/mixed linking. (Closed)

Created:
6 years, 3 months ago by Junichi Uekawa
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Project:
nacl
Visibility:
Public.

Description

NonSFI mode: Add libcrt_platform for native/mixed linking. For ARM link failure happens trying to link exception_test.o because of missing __aeabi_read_tp symbol, this solves the problem. $ ./scons -j20 --mode=dbg-host,nacl_irt_test bitcode=1 nonsfi_nacl=1 \ pnacl_generate_pexe=0 run_exception_test_irt \ use_newlib_nonsfi_loader=0 platform=arm BUG= https://code.google.com/p/chromium/issues/detail?id=408879 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3951 Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=13752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M pnacl/driver/pnacl-driver.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Junichi Uekawa
Hi Derek, I saw you touched here recently. Mark suggested doing this to get exception_test ...
6 years, 3 months ago (2014-09-17 03:46:31 UTC) #2
Mark Seaborn
LGTM
6 years, 3 months ago (2014-09-17 20:34:22 UTC) #3
Derek Schuff
lgtm
6 years, 3 months ago (2014-09-18 04:45:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581463004/1
6 years, 3 months ago (2014-09-18 05:00:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:43:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 13752

Powered by Google App Engine
This is Rietveld 408576698