Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1818)

Issue 581463002: Reland: Minor cleanup in EasyUnlockClient (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 2 months ago
Reviewers:
xiyuan, stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland: Minor cleanup in EasyUnlockClient BUG=None (inherit from the original issue) TBR=stevenjb@chromium.org Orignial issue description: > Minor cleanup in EasyUnlockClient > > * arg names in GenerateEcP256KeyPairCallback typedef were reversed > * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead > of having long list of arguments) > > BUG=None > TEST=existing unittests > > Review URL: https://codereview.chromium.org/569813002 > > Cr-Commit-Position: refs/heads/master@{#294954} Committed: https://crrev.com/4995985a958df189c529aaeb47d405194ab6622c Cr-Commit-Position: refs/heads/master@{#295189}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -245 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc View 1 3 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 3 chunks +3 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 6 chunks +46 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h View 2 chunks +8 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_chromeos.cc View 1 chunk +35 lines, -32 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc View 1 chunk +5 lines, -16 lines 0 comments Download
M chromeos/dbus/easy_unlock_client.h View 2 chunks +66 lines, -40 lines 0 comments Download
M chromeos/dbus/easy_unlock_client.cc View 5 chunks +21 lines, -22 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.h View 1 chunk +2 lines, -11 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.cc View 3 chunks +13 lines, -22 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client_unittest.cc View 2 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tbarzic
xiyuan for chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc
6 years, 3 months ago (2014-09-16 21:46:23 UTC) #2
xiyuan
lgtm
6 years, 3 months ago (2014-09-16 21:48:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/581463002/20001
6 years, 3 months ago (2014-09-16 22:56:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f3baf066ce16b36528a2d4d14eff0d106224f012
6 years, 3 months ago (2014-09-17 00:29:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:29:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4995985a958df189c529aaeb47d405194ab6622c
Cr-Commit-Position: refs/heads/master@{#295189}

Powered by Google App Engine
This is Rietveld 408576698