Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 569813002: Minor cleanup in EasyUnlockClient (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
stevenjb, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup in EasyUnlockClient * arg names in GenerateEcP256KeyPairCallback typedef were reversed * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead of having long list of arguments) BUG=None TEST=existing unittests Committed: https://crrev.com/35e3a9c7061205db58f57182f5ba5eb87be0f355 Cr-Commit-Position: refs/heads/master@{#294954}

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 12 (3 generated)
tbarzic
6 years, 3 months ago (2014-09-15 19:05:15 UTC) #2
tbarzic
+isherman (in case this collides with some of your refactoring)
6 years, 3 months ago (2014-09-15 19:35:09 UTC) #4
stevenjb
lgtm
6 years, 3 months ago (2014-09-15 20:28:34 UTC) #5
Ilya Sherman
Thanks for the heads-up. This doesn't conflict with the refactoring that I'm working on.
6 years, 3 months ago (2014-09-15 21:34:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569813002/20001
6 years, 3 months ago (2014-09-15 23:32:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5eef5ca6d7a1c0829f86fca731ee9adaabb25535
6 years, 3 months ago (2014-09-16 01:02:16 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/35e3a9c7061205db58f57182f5ba5eb87be0f355 Cr-Commit-Position: refs/heads/master@{#294954}
6 years, 3 months ago (2014-09-16 01:05:39 UTC) #10
Ken Rockot(use gerrit already)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/577443004/ by rockot@chromium.org. ...
6 years, 3 months ago (2014-09-16 01:46:10 UTC) #11
tbarzic
6 years, 3 months ago (2014-09-16 21:51:27 UTC) #12
Message was sent while issue was closed.
On 2014/09/16 01:46:10, Ken Rockot wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/577443004/ by mailto:rockot@chromium.org.
> 
> The reason for reverting is: Looks like some ChromeOS code was missed here;
it's
> unclear why bots didn't catch this..

relanding in https://codereview.chromium.org/581463002/

Powered by Google App Engine
This is Rietveld 408576698