Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 581213003: Translate Wimax from Shill -> ONC, fix JS Wimax strings. (Closed)

Created:
6 years, 3 months ago by stevenjb
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, hashimoto+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Translate Wimax from Shill -> ONC, fix JS Wimax strings. This is a follow up CL for 414417 that includes the ONC translation necessary for the Wimax UI and fixes the JS to use the new WiMAX capitalization. It also adds a WiMAX entry to the HTML doc. BUG=414417 Committed: https://crrev.com/9362ad95966777d8689476acbef35a31421831c3 Cr-Commit-Position: refs/heads/master@{#295774}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -20 lines) Patch
M chrome/browser/resources/options/chromeos/internet_detail.js View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/chromeos/network_list.js View 5 chunks +8 lines, -8 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 2 chunks +4 lines, -0 lines 3 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chromeos/test/data/network/shill_wimax_with_state.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_wifi_clientcert.onc View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_wimax_with_state.onc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/onc/docs/onc_spec.html View 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
stevenjb
The Wimax UI can be tested on Linux with '--shill-stub=wimax=1'
6 years, 3 months ago (2014-09-18 22:27:01 UTC) #2
pneubeck (no reviews)
lgtm https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc File chromeos/network/onc/onc_translation_tables.cc (right): https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc#newcode111 chromeos/network/onc/onc_translation_tables.cc:111: // This dictionary is converted during translation, see ...
6 years, 3 months ago (2014-09-19 07:39:24 UTC) #3
stevenjb
https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc File chromeos/network/onc/onc_translation_tables.cc (right): https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc#newcode111 chromeos/network/onc/onc_translation_tables.cc:111: // This dictionary is converted during translation, see onc_translator_*. ...
6 years, 3 months ago (2014-09-19 17:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581213003/1
6 years, 3 months ago (2014-09-19 17:37:55 UTC) #6
pneubeck (no reviews)
https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc File chromeos/network/onc/onc_translation_tables.cc (right): https://codereview.chromium.org/581213003/diff/1/chromeos/network/onc/onc_translation_tables.cc#newcode111 chromeos/network/onc/onc_translation_tables.cc:111: // This dictionary is converted during translation, see onc_translator_*. ...
6 years, 3 months ago (2014-09-19 17:44:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15572)
6 years, 3 months ago (2014-09-19 17:48:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581213003/1
6 years, 3 months ago (2014-09-19 19:10:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9e29c42d5cb20c84ffc026c96e0abd685fec036f
6 years, 3 months ago (2014-09-19 21:03:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 42821b1d481452b037a3e5349f739952e5555b4c
6 years, 3 months ago (2014-09-19 21:04:03 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 21:04:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9362ad95966777d8689476acbef35a31421831c3
Cr-Commit-Position: refs/heads/master@{#295774}

Powered by Google App Engine
This is Rietveld 408576698