Translate Wimax from Shill -> ONC, fix JS Wimax strings.

chromeos/network/onc/onc_translation_tables.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_translation_tables.h"
 
 #include <cstddef>
 
 #include "base/logging.h"
 #include "components/onc/onc_constants.h"
@@ skipping 90 matching lines @@
 const FieldTranslationEntry vpn_fields[] = {
     { ::onc::vpn::kAutoConnect, shill::kAutoConnectProperty},
     // These fields are converted during translation, see onc_translator_*.
     // { ::onc::vpn::kHost, shill::kProviderHostProperty},
     // { ::onc::vpn::kType, shill::kProviderTypeProperty },
     {NULL}};
 
 const FieldTranslationEntry wifi_fields[] = {
     { ::onc::wifi::kAutoConnect, shill::kAutoConnectProperty},
     { ::onc::wifi::kBSSID, shill::kWifiBSsid},
+    // This dictionary is converted during translation, see onc_translator_*.

[pneubeck (no reviews), 2014/09/19 07:39:23]

usually, I didn't list dictionaries. but I'm ok with listing them also.

[stevenjb, 2014/09/19 17:37:20]

Hmm, you're right, we don't, but... this was the first place I looked to see if
we were translating EAP, so I think it's probably useful to use the same
commenting pattern for dictionaries going forward so I will go ahead and leave
this in.

[pneubeck (no reviews), 2014/09/19 17:44:23]

sounds good.

+    // { ::onc::wifi::kEAP, shill::kEap*},
     { ::onc::wifi::kFrequency, shill::kWifiFrequency},
     { ::onc::wifi::kFrequencyList, shill::kWifiFrequencyListProperty},
     { ::onc::wifi::kHiddenSSID, shill::kWifiHiddenSsid},
     { ::onc::wifi::kPassphrase, shill::kPassphraseProperty},
     // This field is converted during translation, see onc_translator_*.
     // { ::onc::wifi::kSSID, shill::kWifiHexSsid},
     // This field is converted during translation, see onc_translator_*.
     // { ::onc::wifi::kSecurity, shill::kSecurityProperty },
     { ::onc::wifi::kSignalStrength, shill::kSignalStrengthProperty},
     {NULL}};
 
 const FieldTranslationEntry wimax_fields[] = {
     { ::onc::wimax::kAutoConnect, shill::kAutoConnectProperty},
+    // This dictionary is converted during translation, see onc_translator_*.
+    // { ::onc::wimax::kEAP, shill::kEap*},
     { ::onc::wimax::kSignalStrength, shill::kSignalStrengthProperty},
     {NULL}};
 
 const FieldTranslationEntry cellular_apn_fields[] = {
     { ::onc::cellular_apn::kAccessPointName, shill::kApnProperty},
     { ::onc::cellular_apn::kName, shill::kApnNameProperty},
     { ::onc::cellular_apn::kUsername, shill::kApnUsernameProperty},
     { ::onc::cellular_apn::kPassword, shill::kApnPasswordProperty},
     { ::onc::cellular_apn::kLocalizedName, shill::kApnLocalizedNameProperty},
     { ::onc::cellular_apn::kLanguage, shill::kApnLanguageProperty},
@@ skipping 279 matching lines @@
       continue;
     *onc_value = table[i].onc_value;
     return true;
   }
   LOG(ERROR) << "Value '" << shill_value << "' cannot be translated to ONC";
   return false;
 }
 
 }  // namespace onc
 }  // namespace chromeos