Make GrIODB keep pending IO refs on all resources it records into its cmd stream.

Make GrIODB keep pending IO refs on all resources it records into its cmd stream.

BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/b3e3a955b6628acc540ef14854b57abb089e62df

[bsalomon, 2014-09-18 18:57:44]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2014-09-18 18:57:45]

I'm thinking about moving the IOType enum out from GrGpuResourceRef, but will do
that in a separate CL.

[robertphillips, 2014-09-18 19:30:51]

lgtm + nits

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
File include/gpu/GrGpuResourceRef.h (right):

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:18: * Class that wraps a resource referenced by a
GrProgramElement or GrDrawState. It manages
reosource - typo.

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:106: pending on the resource when markPendingIO
is called. */
Was reverting the INHERITED stuff intentional ?

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:162: 
Should this really be const ?

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:345: 
overlength.

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.h (right):

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:131: 
Move fFill right a space ?

[bsalomon, 2014-09-18 19:43:55]

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
File include/gpu/GrGpuResourceRef.h (right):

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:18: * Class that wraps a resource referenced by a
GrProgramElement or GrDrawState. It manages
On 2014/09/18 19:30:51, robertphillips wrote:
> reosource - typo.

Done.

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:106: pending on the resource when markPendingIO
is called. */
On 2014/09/18 19:30:51, robertphillips wrote:
> Was reverting the INHERITED stuff intentional ?

oops.. no

https://codereview.chromium.org/581123002/diff/40001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResourceRef.h:162: 
On 2014/09/18 19:30:51, robertphillips wrote:
> Should this really be const ?

I think so. It is on other similar classes. const SkAutoTFoo<A> means the
SkAutoTFoo is const not the A.

Otherwise this would work:

class A {
public:
   Texture* getTexture() const { return fTexture; }

private:
   Texture* fTexture;
};

but not this:

class A {
public:
   Texture* getTexture() const { return fAuto.get(); }

private:
   SkAutoTFoo<Texture> fAuto;
};

which makes the SkAutoTFoo less useful than a raw ptr.

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:345: 
On 2014/09/18 19:30:51, robertphillips wrote:
> overlength.

Done.

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.h (right):

https://codereview.chromium.org/581123002/diff/40001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.h:131: 
On 2014/09/18 19:30:51, robertphillips wrote:
> Move fFill right a space ?

Done. (moved both to the next tab stop)

[bsalomon, 2014-09-18 19:43:58]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-18 19:44:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/581123002/60001

[commit-bot: I haz the power, 2014-09-18 19:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 19:48:32]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)

[bsalomon, 2014-09-19 17:40:12]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-19 17:40:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581123002/80001

[commit-bot: I haz the power, 2014-09-19 17:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 17:47:25]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)

[bsalomon, 2014-09-19 18:01:53]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-19 18:03:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/581123002/100001

[commit-bot: I haz the power, 2014-09-19 18:10:44]

Committed patchset #6 (id:100001) as b3e3a955b6628acc540ef14854b57abb089e62df