Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 580903008: [Android] Create native lib placeholder files (Closed)

Created:
6 years, 3 months ago by Feng Qian
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, kerz_chromium
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, klobag.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Create native lib placeholder files Add an action to create placeholder files in native lib directory. BUG=395038 Committed: https://crrev.com/f1f754bf3385a6f90c45ea4131844e671147f44f Cr-Commit-Position: refs/heads/master@{#295409}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge libfix.crbug.384638.so into placeholder action. #

Patch Set 3 : make stamp dependency conditional, fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
A build/android/gyp/create_placeholder_files.py View 1 chunk +35 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 4 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Feng Qian
6 years, 3 months ago (2014-09-18 00:55:34 UTC) #2
cjhopman
https://codereview.chromium.org/580903008/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/580903008/diff/1/build/java_apk.gypi#newcode411 build/java_apk.gypi:411: '<(apk_package_native_libs_dir)/<(android_app_abi)/libfix.crbug.384638.so', Update this to use the new placeholder action ...
6 years, 3 months ago (2014-09-18 01:07:24 UTC) #3
cjhopman
lgtm
6 years, 3 months ago (2014-09-18 01:53:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580903008/20001
6 years, 3 months ago (2014-09-18 01:57:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/9935)
6 years, 3 months ago (2014-09-18 02:08:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580903008/40001
6 years, 3 months ago (2014-09-18 03:01:05 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c96e7f46bb07587acfb4e996a1acf8f804ac26d0
6 years, 3 months ago (2014-09-18 03:57:34 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 04:10:06 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1f754bf3385a6f90c45ea4131844e671147f44f
Cr-Commit-Position: refs/heads/master@{#295409}

Powered by Google App Engine
This is Rietveld 408576698