Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2637)

Unified Diff: build/java_apk.gypi

Issue 580903008: [Android] Create native lib placeholder files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make stamp dependency conditional, fix build error Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/create_placeholder_files.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index f32385323dfd94f30743eb93feee0e393ce40df2..2c9f4a595b896cde85a8d663dee91e65afe0e029 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -173,6 +173,8 @@
'unsigned_standalone_apk_path': '<(unsigned_standalone_apk_path)',
'libchromium_android_linker': 'libchromium_android_linker.>(android_product_extension)',
'extra_native_libs': [],
+ 'native_lib_placeholder_stamp': '<(apk_package_native_libs_dir)/<(android_app_abi)/native_lib_placeholder.stamp',
+ 'native_lib_placeholders': [],
},
# Pass the jar path to the apk's "fake" jar target. This would be better as
# direct_dependent_settings, but a variable set by a direct_dependent_settings
@@ -384,15 +386,35 @@
},
'includes': ['../build/android/strip_native_libraries.gypi'],
},
+ {
+ 'action_name': 'Create native lib placeholder files for previous releases',
+ 'variables': {
+ 'placeholders': ['<@(native_lib_placeholders)'],
+ 'conditions': [
+ ['gyp_managed_install == 1', {
+ # This "library" just needs to be put in the .apk. It is not loaded
+ # at runtime.
+ 'placeholders': ['libfix.crbug.384638.so'],
+ }]
+ ],
+ },
+ 'inputs': [
+ '<(DEPTH)/build/android/gyp/create_placeholder_files.py',
+ ],
+ 'outputs': [
+ '<(native_lib_placeholder_stamp)',
+ ],
+ 'action': [
+ 'python', '<(DEPTH)/build/android/gyp/create_placeholder_files.py',
+ '--dest-lib-dir=<(apk_package_native_libs_dir)/<(android_app_abi)/',
+ '--stamp=<(native_lib_placeholder_stamp)',
+ '<@(placeholders)',
+ ],
+ },
],
'conditions': [
['gyp_managed_install == 1', {
'variables': {
- # This "library" just needs to be put in the .apk. It is not loaded
- # at runtime.
- 'placeholder_native_library_path':
- '<(apk_package_native_libs_dir)/<(android_app_abi)/libfix.crbug.384638.so',
- 'package_input_paths': [ '<(placeholder_native_library_path)' ],
'libraries_top_dir': '<(intermediate_dir)/lib.stripped',
'libraries_source_dir': '<(libraries_top_dir)/lib/<(android_app_abi)',
'device_library_dir': '<(device_intermediate_dir)/lib.stripped',
@@ -406,19 +428,6 @@
'includes': ['../build/android/push_libraries.gypi'],
},
{
- 'action_name': 'create placeholder lib',
- 'inputs': [
- '<(DEPTH)/build/android/gyp/touch.py',
- ],
- 'outputs': [
- '<(placeholder_native_library_path)',
- ],
- 'action' : [
- 'python', '<(DEPTH)/build/android/gyp/touch.py',
- '<@(_outputs)',
- ],
- },
- {
'action_name': 'create device library symlinks',
'message': 'Creating links on device for <(_target_name)',
'inputs': [
@@ -867,6 +876,11 @@
'outputs': [
'<(unsigned_apk_path)',
],
+ 'conditions': [
+ ['native_lib_target != ""', {
+ 'inputs': ['<(native_lib_placeholder_stamp)'],
+ }],
+ ],
'action': [
'python', '<(DEPTH)/build/android/gyp/ant.py',
'--',
« no previous file with comments | « build/android/gyp/create_placeholder_files.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698