Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 580593003: Reland Safebrowsing: allow sending enhanced download protection pings on OSX. (Closed)

Created:
6 years, 3 months ago by mattm
Modified:
6 years, 3 months ago
Reviewers:
noé
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland Safebrowsing: allow sending enhanced download protection pings on OSX. The re-land fixes the unittests to test with/without the field trial set. Sending is controlled by a finch experiment. The verdict from the server is ignored for now. BUG=413967 Committed: https://crrev.com/c682493aea96e57a0bd759867f5813ec2486f0cc Cr-Commit-Position: refs/heads/master@{#295227}

Patch Set 1 : original cl #

Patch Set 2 : fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -12 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 4 chunks +22 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 9 chunks +74 lines, -4 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/download_protection_util.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mattm
6 years, 3 months ago (2014-09-17 02:32:15 UTC) #3
noé
lgtm
6 years, 3 months ago (2014-09-17 02:34:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580593003/40001
6 years, 3 months ago (2014-09-17 02:49:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 9d85e6e61d8538f2931ab5a185f8ac06691a380f
6 years, 3 months ago (2014-09-17 04:27:51 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 04:28:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c682493aea96e57a0bd759867f5813ec2486f0cc
Cr-Commit-Position: refs/heads/master@{#295227}

Powered by Google App Engine
This is Rietveld 408576698