chrome/common/safe_browsing/csd.proto - Issue 580593003: Reland Safebrowsing: allow sending enhanced download protection pings on OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 580593003: Reland Safebrowsing: allow sending enhanced download protection pings on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/common/safe_browsing/download_protection_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index 67757922ddaa0bebaaaa4498b01818a73ea60a53..ca77f3b91ef5c8e59ede8c7f8a0751e7231c9ec0 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -215,8 +215,9 @@ message ClientDownloadRequest {

WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files.

CHROME_EXTENSION = 1; // .crx files.

ANDROID_APK = 2; // .apk files.

- // .zip files containing one of the above executable types.

+ // .zip files containing one of the other executable types.

ZIPPED_EXECUTABLE = 3;

+ MAC_EXECUTABLE = 4; // .dmg, .pkg, etc.

}

optional DownloadType download_type = 10 [default = WIN_EXECUTABLE];