Issue 580363005: Remove some dead favicon code in RenderViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 580363005: Remove some dead favicon code in RenderViewImpl. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@manifest_icons_sizes

Project:
chromium

Visibility:
Public.

Remove some dead favicon code in RenderViewImpl. BUG=None Committed: https://crrev.com/6d2d4f112f97032a362b74cfbc0bfd4edc33554a Cr-Commit-Position: refs/heads/master@{#296375}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	content/renderer/render_view_impl.h	View		2 chunks	+0 lines, -15 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580363005/1

6 years, 3 months ago (2014-09-24 09:41:14 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 30d070bac4b8a5c58dfb83ce05bfb909701ae55b

6 years, 3 months ago (2014-09-24 09:46:48 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 09:47:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6d2d4f112f97032a362b74cfbc0bfd4edc33554a
Cr-Commit-Position: refs/heads/master@{#296375}