Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 580363005: Remove some dead favicon code in RenderViewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest_icons_sizes
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 namespace ui { 119 namespace ui {
120 struct SelectedFileInfo; 120 struct SelectedFileInfo;
121 } 121 }
122 122
123 namespace content { 123 namespace content {
124 124
125 class BrowserPluginManager; 125 class BrowserPluginManager;
126 class DevToolsAgent; 126 class DevToolsAgent;
127 class DocumentState; 127 class DocumentState;
128 class FaviconHelper;
129 class HistoryController; 128 class HistoryController;
130 class HistoryEntry; 129 class HistoryEntry;
131 class ImageResourceFetcher; 130 class ImageResourceFetcher;
132 class MouseLockDispatcher; 131 class MouseLockDispatcher;
133 class NavigationState; 132 class NavigationState;
134 class PepperPluginInstanceImpl; 133 class PepperPluginInstanceImpl;
135 class RenderViewImplTest; 134 class RenderViewImplTest;
136 class RenderViewObserver; 135 class RenderViewObserver;
137 class RenderViewTest; 136 class RenderViewTest;
138 class RendererDateTimePicker; 137 class RendererDateTimePicker;
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 const gfx::Rect& view_frame); 746 const gfx::Rect& view_frame);
748 #endif 747 #endif
749 748
750 // Adding a new message handler? Please add it in alphabetical order above 749 // Adding a new message handler? Please add it in alphabetical order above
751 // and put it in the same position in the .cc file. 750 // and put it in the same position in the .cc file.
752 751
753 // Misc private functions ---------------------------------------------------- 752 // Misc private functions ----------------------------------------------------
754 // Check whether the preferred size has changed. 753 // Check whether the preferred size has changed.
755 void CheckPreferredSize(); 754 void CheckPreferredSize();
756 755
757 // This callback is triggered when DownloadFavicon completes, either
758 // succesfully or with a failure. See DownloadFavicon for more
759 // details.
760 void DidDownloadFavicon(ImageResourceFetcher* fetcher,
761 const SkBitmap& image);
762
763 // Requests to download a favicon image. When done, the RenderView is notified
764 // by way of DidDownloadFavicon. Returns true if the request was successfully
765 // started, false otherwise. id is used to uniquely identify the request and
766 // passed back to the DidDownloadFavicon method. If the image has multiple
767 // frames, the frame whose size is image_size is returned. If the image
768 // doesn't have a frame at the specified size, the first is returned.
769 bool DownloadFavicon(int id, const GURL& image_url, int image_size);
770
771 // Called to get the WebPlugin to handle find requests in the document. 756 // Called to get the WebPlugin to handle find requests in the document.
772 // Returns NULL if there is no such WebPlugin. 757 // Returns NULL if there is no such WebPlugin.
773 blink::WebPlugin* GetWebPluginForFind(); 758 blink::WebPlugin* GetWebPluginForFind();
774 759
775 // Returns true if the |params| navigation is to an entry that has been 760 // Returns true if the |params| navigation is to an entry that has been
776 // cropped due to a recent navigation the browser did not know about. 761 // cropped due to a recent navigation the browser did not know about.
777 bool IsBackForwardToStaleEntry(const FrameMsg_Navigate_Params& params, 762 bool IsBackForwardToStaleEntry(const FrameMsg_Navigate_Params& params,
778 bool is_reload); 763 bool is_reload);
779 764
780 // Make the given |frame| show an empty, unscriptable page. 765 // Make the given |frame| show an empty, unscriptable page.
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 // use the Observer interface to filter IPC messages and receive frame change 1116 // use the Observer interface to filter IPC messages and receive frame change
1132 // notifications. 1117 // notifications.
1133 // --------------------------------------------------------------------------- 1118 // ---------------------------------------------------------------------------
1134 1119
1135 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1120 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1136 }; 1121 };
1137 1122
1138 } // namespace content 1123 } // namespace content
1139 1124
1140 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1125 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698